Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos #571

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 31, 2021

Backport of JDK-8233570.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/571/head:pull/571
$ git checkout pull/571

Update a local copy of the PR:
$ git checkout pull/571
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/571/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 571

View PR using the GUI difftool:
$ git pr show -t 571

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/571.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a5b42ec8b29249814dda28e751ee363869e98da0 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos Oct 31, 2021
@openjdk
Copy link

openjdk bot commented Oct 31, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 31, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 31, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 5, 2021

Going to push as commit 889840b.
Since your change was applied there have been 2 commits pushed to the master branch:

  • e929b18: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
  • 5aa125e: 8276066: Reset LoopPercentProfileLimit for x86 due to suboptimal performance

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 5, 2021
@openjdk
Copy link

openjdk bot commented Nov 5, 2021

@RealCLanger Pushed as commit 889840b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-a5b42ec8 branch November 5, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant