8273026: Slow LoginContext.login() on multi threading application #572

Larry-N · 2021-11-01T15:53:06Z

Backport of performance enhancement. Tested with tier-2.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8273026: Slow LoginContext.login() on multi threading application

Reviewers

Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/572/head:pull/572
$ git checkout pull/572

Update a local copy of the PR:
$ git checkout pull/572
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/572/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 572

View PR using the GUI difftool:
$ git pr show -t 572

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/572.diff

bridgekeeper · 2021-11-01T15:53:16Z

👋 Welcome back Larry-N! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-11-01T15:54:45Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2021-11-01T16:03:33Z

Webrevs

RealCLanger

The .gitignore file should not be deleted...

This reverts commit b49f2df.

Larry-N · 2021-11-10T13:18:17Z

Sorry, thanks. Corrected this.

RealCLanger · 2021-11-17T13:29:38Z

src/java.base/share/classes/javax/security/auth/login/LoginContext.java

+                            if (debug != null){
+                                debug.println("Build ServiceProviders cache for ClassLoader: " + contextClassLoader.getName());
+                            }
+                            @SuppressWarnings("removal")


I guess in 11 you don't need this @SuppressWarnings("removal") directive since the deprecation for Security Manager was done later.

RealCLanger · 2021-11-17T13:30:27Z

I looked at this now. Except from the minor comment regarding the SuppressWarnings, it looks good to me. I'll run it through our nightlies once more.

Larry-N · 2021-11-17T14:49:14Z

Thanks, Christoph. I've removed redundant SupressWarning

RealCLanger

LGTM

openjdk · 2021-11-18T12:27:38Z

@Larry-N This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273026: Slow LoginContext.login() on multi threading application

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

770a78a: 8210182: Remove macros for C compilation from vmTestBase but non jvmti
63277a4: 8226943: compile error in libfollowref003.cpp with XCode 10.2 on macosx
4b591db: 8209611: use C++ compiler for hotspot tests
5e08548: 8274860: gcc 10.2.1 produces an uninitialized warning in sharedRuntimeTrig.cpp
9b94409: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
ed9a41b: 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766
ccd7a6f: 8275766: (tz) Update Timezone Data to 2021e
d9b2c4c: 8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64
1b4eb43: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
0d0aa7c: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert
... and 41 more: https://git.openjdk.java.net/jdk11u-dev/compare/4a99728820bf35b44bca09d0b3deabc8981898ae...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Larry-N · 2021-11-22T13:23:03Z

/integrate

openjdk · 2021-11-22T13:23:56Z

@Larry-N
Your change (at version 8993e53) is now ready to be sponsored by a Committer.

RealCLanger · 2021-11-22T16:06:53Z

/sponsor

openjdk · 2021-11-22T16:08:29Z

Going to push as commit 2fb8ca2.
Since your change was applied there have been 52 commits pushed to the master branch:

e2b7f1e: 8210198: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[A-F] tests
770a78a: 8210182: Remove macros for C compilation from vmTestBase but non jvmti
63277a4: 8226943: compile error in libfollowref003.cpp with XCode 10.2 on macosx
4b591db: 8209611: use C++ compiler for hotspot tests
5e08548: 8274860: gcc 10.2.1 produces an uninitialized warning in sharedRuntimeTrig.cpp
9b94409: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
ed9a41b: 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766
ccd7a6f: 8275766: (tz) Update Timezone Data to 2021e
d9b2c4c: 8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64
1b4eb43: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
... and 42 more: https://git.openjdk.java.net/jdk11u-dev/compare/4a99728820bf35b44bca09d0b3deabc8981898ae...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-11-22T16:08:48Z

@RealCLanger @Larry-N Pushed as commit 2fb8ca2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Backport c0cda1db4fe74b86faa12136336bdf98c96758d2

1ade9e6

openjdk bot changed the title ~~Backport c0cda1db4fe74b86faa12136336bdf98c96758d2~~ 8273026: Slow LoginContext.login() on multi threading application Nov 1, 2021

openjdk bot added backport rfr Pull request is ready for review labels Nov 1, 2021

Delete .gitignore

b49f2df

RealCLanger suggested changes Nov 9, 2021

View reviewed changes

Larry-N added 2 commits November 10, 2021 15:09

Revert "Delete .gitignore"

eda8bff

This reverts commit b49f2df.

corrections in .gitignore

98ea1b8

RealCLanger reviewed Nov 17, 2021

View reviewed changes

Review notes

8993e53

RealCLanger approved these changes Nov 18, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2021

openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 22, 2021

openjdk bot closed this Nov 22, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 22, 2021

8273026: Slow LoginContext.login() on multi threading application #572

8273026: Slow LoginContext.login() on multi threading application #572

Larry-N commented Nov 1, 2021 •

edited by openjdk bot

bridgekeeper bot commented Nov 1, 2021

openjdk bot commented Nov 1, 2021

mlbridge bot commented Nov 1, 2021 •

edited

RealCLanger left a comment

Larry-N commented Nov 10, 2021 •

edited

RealCLanger Nov 17, 2021

RealCLanger commented Nov 17, 2021

Larry-N commented Nov 17, 2021

RealCLanger left a comment

openjdk bot commented Nov 18, 2021 •

edited

Larry-N commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

RealCLanger commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

8273026: Slow LoginContext.login() on multi threading application #572

8273026: Slow LoginContext.login() on multi threading application #572

Conversation

Larry-N commented Nov 1, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Nov 1, 2021

openjdk bot commented Nov 1, 2021

mlbridge bot commented Nov 1, 2021 • edited

Webrevs

RealCLanger left a comment

Choose a reason for hiding this comment

Larry-N commented Nov 10, 2021 • edited

RealCLanger Nov 17, 2021

Choose a reason for hiding this comment

RealCLanger commented Nov 17, 2021

Larry-N commented Nov 17, 2021

RealCLanger left a comment

Choose a reason for hiding this comment

openjdk bot commented Nov 18, 2021 • edited

Larry-N commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

RealCLanger commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

openjdk bot commented Nov 22, 2021

Larry-N commented Nov 1, 2021 •

edited by openjdk bot

mlbridge bot commented Nov 1, 2021 •

edited

Larry-N commented Nov 10, 2021 •

edited

openjdk bot commented Nov 18, 2021 •

edited