8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS

[apavlyutkin]

I'd like to backport JDK-8190753 to jdk11u

The fix prevents using a result of Add-n-Shift operation as an input for CAS operation that takes only register operands for Aarch64

The original patch applied cleanly

Testing: original patch does not have verification tests. Regression: hotspot_all (arm64/20.04 LTS)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS

Reviewers

• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/573/head:pull/573
$ git checkout pull/573

Update a local copy of the PR:
$ git checkout pull/573
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/573/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 573

View PR using the GUI difftool:
$ git pr show -t 573

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/573.diff

[bridgekeeper]

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 74 new commits pushed to the master branch:

• 38a2505: 8256009: Remove src/hotspot/share/adlc/Test/i486.ad
• 299e6c8: 8256182: Update qemu-debootstrap cross-compilation recipe
• 3a35158: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
• 1d2fee0: 8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos
• 8dc5f14: 8233641: [TESTBUG] JMenuItem test bug4171437.java fails on macos
• ca35b75: 8233560: [TESTBUG] ToolTipManager/Test6256140.java is failing on macos
• 73cbc72: 8248500: AArch64: Remove the r18 dependency on Windows AArch64
• 889840b: 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos
• e929b18: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
• 5aa125e: 8276066: Reset LoopPercentProfileLimit for x86 due to suboptimal performance
• ... and 64 more: https://git.openjdk.java.net/jdk11u-dev/compare/d5017c378c0624a6e2f1ec00fa5333b01f4c6fb2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (f69cfa5f)

[GoeLin]

Hi Alexey, you need to add a "Fix Request 11u" comment in the JBS issue, please. See also http://openjdk.java.net/projects/jdk-updates/approval.html Rule 1.

[apavlyutkin]

Hi Alexey, you need to add a "Fix Request 11u" comment in the JBS issue, please. See also http://openjdk.java.net/projects/jdk-updates/approval.html Rule 1.

Hi Goetz! Yeap, I know. I just took a break trying to create a verification test. Thank you

[theRealAph]

Hi Alexey, you need to add a "Fix Request 11u" comment in the JBS issue, please. See also http://openjdk.java.net/projects/jdk-updates/approval.html Rule 1.

Hi Goetz! Yeap, I know. I just took a break trying to create a verification test. Thank you

I think the bug is latent in 11, so provoking it will be very hard. I don't think you need a new test.

[apavlyutkin]

/integrate

[openjdk]

@apavlyutkin
Your change (at version f69cfa5) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit 2221f37.
Since your change was applied there have been 75 commits pushed to the master branch:

• 0022605: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos
• 38a2505: 8256009: Remove src/hotspot/share/adlc/Test/i486.ad
• 299e6c8: 8256182: Update qemu-debootstrap cross-compilation recipe
• 3a35158: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
• 1d2fee0: 8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos
• 8dc5f14: 8233641: [TESTBUG] JMenuItem test bug4171437.java fails on macos
• ca35b75: 8233560: [TESTBUG] ToolTipManager/Test6256140.java is failing on macos
• 73cbc72: 8248500: AArch64: Remove the r18 dependency on Windows AArch64
• 889840b: 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos
• e929b18: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
• ... and 65 more: https://git.openjdk.java.net/jdk11u-dev/compare/d5017c378c0624a6e2f1ec00fa5333b01f4c6fb2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @apavlyutkin Pushed as commit 2221f37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.