Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267304: Bump global JTReg memory limit to 768m #575

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 2, 2021

Clean backport to improve testing speed.

Additional testing:

  • Linux x86_64 fastdebug tier1

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/575/head:pull/575
$ git checkout pull/575

Update a local copy of the PR:
$ git checkout pull/575
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/575/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 575

View PR using the GUI difftool:
$ git pr show -t 575

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/575.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e749f75de015fd9ef47f7a962f232e2ea677aba5 8267304: Bump global JTReg memory limit to 768m Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267304: Bump global JTReg memory limit to 768m

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 2, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Nov 4, 2021

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2021

Going to push as commit 1ae1563.
Since your change was applied there has been 1 commit pushed to the master branch:

  • ad40b61: 8235784: java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java fails due to timeout with fastdebug bits

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2021
@openjdk
Copy link

openjdk bot commented Nov 4, 2021

@shipilev Pushed as commit 1ae1563.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8267304-bump-jtreg-mem branch Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant