Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231717: Improve performance of charset decoding when charset is always compactable #58

Closed
wants to merge 1 commit into from

Conversation

@dchuyko
Copy link
Member

@dchuyko dchuyko commented Jun 23, 2021

This change improves charset decoding for a number of encodings that are "Latin1Decodable". Original patch applies cleanly.

Testing: tier1, tier2, sun/nio/cs on aarch64 and x86.

StrCodingBenchmark benchmark shows improvements for target encodings (IBM037 etc.) on both aarch64 and x86.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8231717: Improve performance of charset decoding when charset is always compactable

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/58/head:pull/58
$ git checkout pull/58

Update a local copy of the PR:
$ git checkout pull/58
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/58/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 58

View PR using the GUI difftool:
$ git pr show -t 58

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/58.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 23, 2021

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 0dbfc97c05218ffd10242901d73c0715ccb53bf3 8231717: Improve performance of charset decoding when charset is always compactable Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@dchuyko This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8231717: Improve performance of charset decoding when charset is always compactable

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 48c1f60: 8263227: C2: inconsistent spilling due to dead nodes in exception block
  • dcd1044: 8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API
  • ed48e5c: 8226533: JVMCI: findUniqueConcreteMethod should handle statically bindable methods directly
  • 8d5b37a: 8223050: JVMCI: findUniqueConcreteMethod() should not use Dependencies::find_unique_concrete_method() for non-virtual methods
  • 3f67b07: 8267751: (test) jtreg.SkippedException has no serial VersionUID
  • 46fd6d2: 8263382: java/util/logging/ParentLoggersTest.java failed with "checkLoggers: getLoggerNames() returned unexpected loggers"
  • 881100f: 8233989: Create an IPv4 version of java/net/MulticastSocket/SetLoopbackMode.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 23, 2021

Webrevs

Loading

@dchuyko
Copy link
Member Author

@dchuyko dchuyko commented Jun 24, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Jun 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@dchuyko
Your change (at version 33048ef) is now ready to be sponsored by a Committer.

Loading

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 24, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

Going to push as commit 34d1c92.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 48c1f60: 8263227: C2: inconsistent spilling due to dead nodes in exception block
  • dcd1044: 8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API
  • ed48e5c: 8226533: JVMCI: findUniqueConcreteMethod should handle statically bindable methods directly
  • 8d5b37a: 8223050: JVMCI: findUniqueConcreteMethod() should not use Dependencies::find_unique_concrete_method() for non-virtual methods
  • 3f67b07: 8267751: (test) jtreg.SkippedException has no serial VersionUID
  • 46fd6d2: 8263382: java/util/logging/ParentLoggersTest.java failed with "checkLoggers: getLoggerNames() returned unexpected loggers"
  • 881100f: 8233989: Create an IPv4 version of java/net/MulticastSocket/SetLoopbackMode.java

Your commit was automatically rebased without conflicts.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@RealCLanger @dchuyko Pushed as commit 34d1c92.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants