-
Notifications
You must be signed in to change notification settings - Fork 240
8231717: Improve performance of charset decoding when charset is always compactable #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@dchuyko This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 34d1c92.
Your commit was automatically rebased without conflicts. |
@RealCLanger @dchuyko Pushed as commit 34d1c92. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This change improves charset decoding for a number of encodings that are "Latin1Decodable". Original patch applies cleanly.
Testing: tier1, tier2, sun/nio/cs on aarch64 and x86.
StrCodingBenchmark benchmark shows improvements for target encodings (IBM037 etc.) on both aarch64 and x86.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/58/head:pull/58
$ git checkout pull/58
Update a local copy of the PR:
$ git checkout pull/58
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/58/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 58
View PR using the GUI difftool:
$ git pr show -t 58
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/58.diff