-
Notifications
You must be signed in to change notification settings - Fork 239
8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror" #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add the comment from JvmtiGetLoadedClasses::getLoadedClasses() before the added MultiArray_lock in metaspaceShared.cpp, vis
// To get a consistent list of classes we need MultiArray_lock to ensure
// array classes aren't created.
Otherwise, lgtm.
Thanks for the review, @phohensee . Added comment as you suggested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Zhengyu. Lgtm.
@zhengyu123 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 3a35158.
Your commit was automatically rebased without conflicts. |
@zhengyu123 Pushed as commit 3a35158. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Mailing list message from Lindenmaier, Goetz on jdk-updates-dev: Hi Zhengyu, Since this change has been pushed, we see four test crashing in our CI, Best regards, runtime/appcds/UnusedCPDuringDump.java # A fatal error has been detected by the Java Runtime Environment: --------------- S U M M A R Y ------------ Command Line: -Xmx768m -Djava.awt.headless=true -Djava.util.prefs.userRoot=/System/Volumes/Data/priv/jvmtests/output_openjdk11_dev_dbgU_darwinintel64/jtreg_hotspot_runtime_work/tmp -Djava.io.tmpdir=/System/Volumes/Data/priv/jvmtests/output_openjdk11_dev_dbgU_darwinintel64/jtreg_hotspot_runtime_work/tmp -Djdk.test.lib.artifacts.devkit-macosx_x64=/net/usr.work/jvmtests/devkit/Xcode9.2-MacOSX10.13-devkit -ea -esa -Xshare:dump -Xlog:cds,cds+hashtables -XX:ExtraSharedClassListFile=/System/Volumes/Data/priv/jvmtests/output_openjdk11_dev_dbgU_darwinintel64/jtreg_hotspot_runtime_work/JTwork/classes/runtime/appcds/UnusedCPDuringDump.d/runtime.appcds.UnusedCPDuringDump.java-test.classlist -XX:SharedArchiveFile=/System/Volumes/Data/priv/jvmtests/output_openjdk11_dev_dbgU_darwinintel64/jtreg_hotspot_runtime_work/JTwork/runtime/appcds/UnusedCPDuringDump/appcds-22h03m26s830.jsa -Xlog:class+path=info,class+load=debug Host: wdfmacphy0129.wdf.global.corp.sap, MacPro7,1 x86_64 3200 MHz, 32 cores, 96G, Darwin 20.6.0 --------------- T H R E A D --------------- Current thread (0x00007fe56f808620): JavaThread "main" [_thread_in_vm, id=9987, stack(0x0000700002ad5000,0x0000700002bd5000)] Stack: [0x0000700002ad5000,0x0000700002bd5000], sp=0x0000700002bd2430, free space=1013k -----Original Message----- On Thu, 4 Nov 2021 16:32:16 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:
This pull request has now been integrated. Changeset: 3a35158 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror" Reviewed-by: phh ------------- PR: https://git.openjdk.java.net/jdk11u-dev/pull/584 |
Mailing list message from David Holmes on jdk-updates-dev: On 9/11/2021 10:50 pm, Lindenmaier, Goetz wrote:
From JBS: "The original patch applies cleanly, but needs to take additional but that additional change is broken as you can't hold the lock on that David |
Hi David, Sorry, I did not see your comment until now. Adding MultiArray_lock on CDS path, as stated in comment, was to workaround the new assertion in ClassLoaderData::loaded_classes_do() in following code:
I revised patch to drop the new assertion in Thanks, -Zhengyu |
Backport for parity with Oracle 11.0.15.
The original patch applies cleanly, but some of CDS tests fail due to following new assertion in
ClassLoaderData::loaded_classes_do()
// To call this, one must have the MultiArray_lock held, but the _klasses list still has lock free reads. assert_locked_or_safepoint(MultiArray_lock);
The solution is to take
MultiArray_lock
inMetaspaceShared::link_and_cleanup_shared_classes()
methodTest:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/584/head:pull/584
$ git checkout pull/584
Update a local copy of the PR:
$ git checkout pull/584
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/584/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 584
View PR using the GUI difftool:
$ git pr show -t 584
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/584.diff