Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos #587

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 4, 2021

Backport of JDK-8233637.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/587/head:pull/587
$ git checkout pull/587

Update a local copy of the PR:
$ git checkout pull/587
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 587

View PR using the GUI difftool:
$ git pr show -t 587

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/587.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 4, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 98c91b64b2bfaf16a59f42a58fb86346d2b4261d 8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos Nov 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233637: [TESTBUG] Swing ActionListenerCalledTwiceTest.java fails on macos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 4, 2021

Webrevs

@RealCLanger RealCLanger force-pushed the RealCLanger-backport-98c91b64 branch from c20cf82 to e2d8075 Nov 5, 2021
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Nov 6, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 6, 2021

Going to push as commit 1d2fee0.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 8dc5f14: 8233641: [TESTBUG] JMenuItem test bug4171437.java fails on macos
  • ca35b75: 8233560: [TESTBUG] ToolTipManager/Test6256140.java is failing on macos
  • 73cbc72: 8248500: AArch64: Remove the r18 dependency on Windows AArch64
  • 889840b: 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos
  • e929b18: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
  • 5aa125e: 8276066: Reset LoopPercentProfileLimit for x86 due to suboptimal performance

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 6, 2021

@RealCLanger Pushed as commit 1d2fee0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-98c91b64 branch Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant