Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit #588

Closed

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Nov 5, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/588/head:pull/588
$ git checkout pull/588

Update a local copy of the PR:
$ git checkout pull/588
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/588/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 588

View PR using the GUI difftool:
$ git pr show -t 588

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/588.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1ea437a4b87381b558cf8157ac52fc03e37ac507 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@DamonFool This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 5aa125e: 8276066: Reset LoopPercentProfileLimit for x86 due to suboptimal performance
  • 51390ac: 8233556: [TESTBUG] JPopupMenu tests fail on MacOS
  • a855b6f: 8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Nov 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2021

Webrevs

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 5, 2021

The crash in GHA Windows build is a bit concerning... Maybe it's just infrastructure related, though. @DamonFool, could you check this?

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Nov 5, 2021

The crash in GHA Windows build is a bit concerning... Maybe it's just infrastructure related, though. @DamonFool, could you check this?

Hi @RealCLanger ,

Thanks for your review.

The crash happened in make which shouldn't be caused by the hotspot code change.

/usr/bin/bash: line 1:  1076 Segmentation fault      (core dumped) /usr/bin/make -s -r -R -I /cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/make/common SPEC=/cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/build/windows-x64/spec.gmk MAKE_LOG_FLAGS="-s" -f ModuleWrapper.gmk -I/cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/make -I/cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/make/copy MODULE=java.base MAKEFILE_PREFIX=Copy

In theory, there is no risk for this backport.
Thanks.

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Nov 5, 2021

Fix request had been approved.
So integrate it.
/integrate.

Thanks.

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Nov 5, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@DamonFool
Your change (at version c8ecbc8) is now ready to be sponsored by a Committer.

@johnshajiang
Copy link
Member

@johnshajiang johnshajiang commented Nov 5, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

Going to push as commit e929b18.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 5aa125e: 8276066: Reset LoopPercentProfileLimit for x86 due to suboptimal performance
  • 51390ac: 8233556: [TESTBUG] JPopupMenu tests fail on MacOS
  • a855b6f: 8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@johnshajiang @DamonFool Pushed as commit e929b18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Nov 5, 2021

/sponsor

Thanks @johnshajiang for your sponsoring.

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 5, 2021

The crash in GHA Windows build is a bit concerning... Maybe it's just infrastructure related, though. @DamonFool, could you check this?

Hi @RealCLanger ,

Thanks for your review.

The crash happened in make which shouldn't be caused by the hotspot code change.

/usr/bin/bash: line 1:  1076 Segmentation fault      (core dumped) /usr/bin/make -s -r -R -I /cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/make/common SPEC=/cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/build/windows-x64/spec.gmk MAKE_LOG_FLAGS="-s" -f ModuleWrapper.gmk -I/cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/make -I/cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/make/copy MODULE=java.base MAKEFILE_PREFIX=Copy

In theory, there is no risk for this backport. Thanks.

OK, yes, it must have been something in the environment. I just ran another GHA tests on a current branch which got past this step: https://github.com/RealCLanger/jdk11u-dev/actions/runs/1424808669

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Nov 5, 2021

The crash in GHA Windows build is a bit concerning... Maybe it's just infrastructure related, though. @DamonFool, could you check this?

Hi @RealCLanger ,
Thanks for your review.
The crash happened in make which shouldn't be caused by the hotspot code change.

/usr/bin/bash: line 1:  1076 Segmentation fault      (core dumped) /usr/bin/make -s -r -R -I /cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/make/common SPEC=/cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/build/windows-x64/spec.gmk MAKE_LOG_FLAGS="-s" -f ModuleWrapper.gmk -I/cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/make -I/cygdrive/d/a/jdk11u-dev/jdk11u-dev/jdk/make/copy MODULE=java.base MAKEFILE_PREFIX=Copy

In theory, there is no risk for this backport. Thanks.

OK, yes, it must have been something in the environment. I just ran another GHA tests on a current branch which got past this step: https://github.com/RealCLanger/jdk11u-dev/actions/runs/1424808669

Thanks @RealCLanger for your experiment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
3 participants