-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8256182: Update qemu-debootstrap cross-compilation recipe #589
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Got the push approval. /integrate |
Going to push as commit 299e6c8.
Your commit was automatically rebased without conflicts. |
Unclean backport to improve cross-build implementation. The uncleanliness comes from the fact that 11u builds are in
linux-aarch64-*normal*-server-release
, so the hunks do not apply cleanly. I just accepted the hunks from the mainline patch and added "normal" manually.Original change was to match the docs with what we run in GHA. The same motivation holds for 11u.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/589/head:pull/589
$ git checkout pull/589
Update a local copy of the PR:
$ git checkout pull/589
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/589/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 589
View PR using the GUI difftool:
$ git pr show -t 589
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/589.diff