8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed

[tstuefe]

Hi,

I'd like to backport "JDK-8263728: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed", since it prevents sporadic gtest errors.

Original commit: openjdk/jdk@8c1112a6

This one is not a clean backport:

• vmError.cpp changed slightly, since https://bugs.openjdk.java.net/browse/JDK-8258479 did some code cleanups for JDK17
• more importantly, this patch touches os::abort(). That function had been unified into os_posix.cpp for all posix platforms with https://bugs.openjdk.java.net/browse/JDK-8263564 for JDK 17. I briefly considered backporting JDK-8263564, but decided against it since it is too invasive and unnecessary. Instead, I changed the various os::abort() implementations for all individual OSes, including Solaris.

Tests: Nightlies at SAP, GHAs.

Thanks, Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/590/head:pull/590
$ git checkout pull/590

Update a local copy of the PR:
$ git checkout pull/590
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/590/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 590

View PR using the GUI difftool:
$ git pr show -t 590

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/590.diff

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[tstuefe]

Windows test error in GHA unrelated.

[mlbridge]

Webrevs

• 01: Full - Incremental (90f9afbc)
• 00: Full (45b85b59)

[GoeLin]

Hi Thomas,
do you have an idea why windows pre-submit tests failed?

[tstuefe]

Hi Thomas, do you have an idea why windows pre-submit tests failed?

Since the last cygwin update bash is crashy, which affects Windows GHAs. I see this all over the place. @shipilev is working on it. https://bugs.openjdk.java.net/browse/JDK-8276854.

Note that the patch has been cooking for a week or so in our internal 11 test systems without problems.

[GoeLin]

Thanks for the explanation ... in the meantime I'm aware of that issue on windows, too!

[GoeLin]

LGTM.
Yes, it is good to spread the change to the os files. Thanks.

[tstuefe]

Thanks @GoeLin . Waiting for approval in JBS.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 6ec651f: 8276550: Use SHA256 hash in build.tools.depend.Depend
• e608a20: 8236596: HttpClient leaves HTTP/2 sockets in CLOSE_WAIT, when using proxy tunnel
• c6242ed: 8276854: Windows GHA builds fail due to broken Cygwin
• 1d62284: 8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac
• 2876be0: 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX
• c406da1: 8276943: Backout JDK-8274338 11u backport
• a15fa7a: 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah
• 29ec865: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X
• a7a9ea8: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS
• d8adeca: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout
• ... and 11 more: https://git.openjdk.java.net/jdk11u-dev/compare/e929b18cb10bb182e3c88c83d0a269e85a590eb9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

/integrate

[openjdk]

Going to push as commit 46d8523.
Since your change was applied there have been 21 commits pushed to the master branch:

• 6ec651f: 8276550: Use SHA256 hash in build.tools.depend.Depend
• e608a20: 8236596: HttpClient leaves HTTP/2 sockets in CLOSE_WAIT, when using proxy tunnel
• c6242ed: 8276854: Windows GHA builds fail due to broken Cygwin
• 1d62284: 8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac
• 2876be0: 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX
• c406da1: 8276943: Backout JDK-8274338 11u backport
• a15fa7a: 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah
• 29ec865: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X
• a7a9ea8: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS
• d8adeca: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout
• ... and 11 more: https://git.openjdk.java.net/jdk11u-dev/compare/e929b18cb10bb182e3c88c83d0a269e85a590eb9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit 46d8523.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.