Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX #594

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 5, 2021

Hi all,

this pull request contains a backport of JDK-8136517 from the openjdk/jdk repository.

The commit being backported was authored by Pankaj Bansal on 28 Apr 2021 and was reviewed by Sergey Bylokhov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/594/head:pull/594
$ git checkout pull/594

Update a local copy of the PR:
$ git checkout pull/594
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 594

View PR using the GUI difftool:
$ git pr show -t 594

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/594.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0438cea65b927bcf3d039b290de7fd7c60a06922 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8136517: [macosx]Test  java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 889840b: 8233570: [TESTBUG] HTMLEditorKit test bug5043626.java is failing on macos
  • e929b18: 8272720: Fix the implementation of loop unrolling heuristic with LoopPercentProfileLimit
  • 5aa125e: 8276066: Reset LoopPercentProfileLimit for x86 due to suboptimal performance
  • 51390ac: 8233556: [TESTBUG] JPopupMenu tests fail on MacOS
  • a855b6f: 8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX
  • fe7ee62: 8223141: Change (count) suffix _ct into _cnt.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Nov 10, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2021

Going to push as commit 2876be0.
Since your change was applied there have been 21 commits pushed to the master branch:

  • c406da1: 8276943: Backout JDK-8274338 11u backport
  • a15fa7a: 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah
  • 29ec865: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X
  • a7a9ea8: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS
  • d8adeca: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout
  • 1e99800: 8267246: -XX:MaxRAMPercentage=0 is unreasonable for jtreg tests on many-core machines
  • 2221f37: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • 0022605: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos
  • 38a2505: 8256009: Remove src/hotspot/share/adlc/Test/i486.ad
  • 299e6c8: 8256182: Update qemu-debootstrap cross-compilation recipe
  • ... and 11 more: https://git.openjdk.java.net/jdk11u-dev/compare/1ae15632c7005eff2267aa6cdbacbc038c4b43c5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2021

@RealCLanger Pushed as commit 2876be0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant