Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout #596

Closed

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Nov 6, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/596/head:pull/596
$ git checkout pull/596

Update a local copy of the PR:
$ git checkout pull/596
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/596/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 596

View PR using the GUI difftool:
$ git pr show -t 596

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/596.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport da643cdb204ecd0c56f7ac1a744b8114171c6bd9 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout Nov 6, 2021
@openjdk
Copy link

openjdk bot commented Nov 6, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 6, 2021

@DamonFool This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 2221f37: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • 0022605: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos
  • 38a2505: 8256009: Remove src/hotspot/share/adlc/Test/i486.ad
  • 299e6c8: 8256182: Update qemu-debootstrap cross-compilation recipe
  • 3a35158: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 6, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2021

Webrevs

@DamonFool
Copy link
Member Author

FYI: Timeout of runtime/Thread/SuspendAtExit.java on Windows x64 was not caused by this patch.
This is a noreg backport.
Thanks.

@DamonFool
Copy link
Member Author

Fix request had been approved.
So integrate it.
Thanks.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 10, 2021
@openjdk
Copy link

openjdk bot commented Nov 10, 2021

@DamonFool
Your change (at version 992cd64) is now ready to be sponsored by a Committer.

@johnshajiang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 10, 2021

Going to push as commit d8adeca.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 1e99800: 8267246: -XX:MaxRAMPercentage=0 is unreasonable for jtreg tests on many-core machines
  • 2221f37: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • 0022605: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos
  • 38a2505: 8256009: Remove src/hotspot/share/adlc/Test/i486.ad
  • 299e6c8: 8256182: Update qemu-debootstrap cross-compilation recipe
  • 3a35158: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 10, 2021
@openjdk
Copy link

openjdk bot commented Nov 10, 2021

@johnshajiang @DamonFool Pushed as commit d8adeca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants