Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64 #597

Closed

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Nov 6, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/597/head:pull/597
$ git checkout pull/597

Update a local copy of the PR:
$ git checkout pull/597
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/597/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 597

View PR using the GUI difftool:
$ git pr show -t 597

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/597.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 6, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b1d149935603a4b1cc2acbaf0de01e42622d4419 8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64 Nov 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 6, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 6, 2021

@DamonFool This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • 1b4eb43: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 0d0aa7c: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert
  • 394a5de: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • c2cda03: 8202342: [Graal] fromTonga/nsk/jvmti/unit/FollowReferences/followref003/TestDescription.java fails with "Location mismatch" errors
  • 35c045c: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • 3593e1e: 8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events
  • 9f7729a: 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows
  • 63848c5: 8201224: Make string buffer size dynamic in mlvmJvmtiUtils.c
  • 18f16db: 8174819: java/nio/file/WatchService/LotsOfEvents.java fails intermittently
  • 4b0cb20: 8204161: [TESTBUG] auto failed with the "Applet thread threw exception: java.lang.UnsupportedOperationException" exception
  • ... and 18 more: https://git.openjdk.java.net/jdk11u-dev/compare/1d2fee04f7530980471992a1716b50b9d2d1d062...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Nov 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 6, 2021

Webrevs

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Nov 18, 2021

Fix request had been approved.
So integrate it.
Thanks.

/integrate

@openjdk openjdk bot added the sponsor label Nov 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 18, 2021

@DamonFool
Your change (at version 890c25c) is now ready to be sponsored by a Committer.

@johnshajiang
Copy link
Member

@johnshajiang johnshajiang commented Nov 18, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 18, 2021

Going to push as commit d9b2c4c.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 1b4eb43: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 0d0aa7c: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert
  • 394a5de: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • c2cda03: 8202342: [Graal] fromTonga/nsk/jvmti/unit/FollowReferences/followref003/TestDescription.java fails with "Location mismatch" errors
  • 35c045c: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • 3593e1e: 8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events
  • 9f7729a: 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows
  • 63848c5: 8201224: Make string buffer size dynamic in mlvmJvmtiUtils.c
  • 18f16db: 8174819: java/nio/file/WatchService/LotsOfEvents.java fails intermittently
  • 4b0cb20: 8204161: [TESTBUG] auto failed with the "Applet thread threw exception: java.lang.UnsupportedOperationException" exception
  • ... and 18 more: https://git.openjdk.java.net/jdk11u-dev/compare/1d2fee04f7530980471992a1716b50b9d2d1d062...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 18, 2021

@johnshajiang @DamonFool Pushed as commit d9b2c4c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants