Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah #602

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 8, 2021

Clean backport to fix one of the tests with Shenandoah.

Additional testing:

  • Linux x86_64 fastdebug, test is now skipped

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/602/head:pull/602
$ git checkout pull/602

Update a local copy of the PR:
$ git checkout pull/602
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/602/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 602

View PR using the GUI difftool:
$ git pr show -t 602

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/602.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c0533ef2d8e526aaec0eebe862f4bbefc159ea37 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah Nov 8, 2021
@openjdk
Copy link

openjdk bot commented Nov 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 8, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2021

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 10, 2021

Going to push as commit a15fa7a.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 29ec865: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X
  • a7a9ea8: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS
  • d8adeca: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout
  • 1e99800: 8267246: -XX:MaxRAMPercentage=0 is unreasonable for jtreg tests on many-core machines
  • 2221f37: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
  • 0022605: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos
  • 38a2505: 8256009: Remove src/hotspot/share/adlc/Test/i486.ad

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2021
@openjdk
Copy link

openjdk bot commented Nov 10, 2021

@shipilev Pushed as commit a15fa7a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8274522-shenandoah-mxexception branch December 21, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant