8208242: Add @requires to vmTestbase/gc/g1 tests

[pmikova]

Backport of JDK-8208242

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8208242: Add @requires to vmTestbase/gc/g1 tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/604/head:pull/604
$ git checkout pull/604

Update a local copy of the PR:
$ git checkout pull/604
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/604/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 604

View PR using the GUI difftool:
$ git pr show -t 604

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/604.diff

[bridgekeeper]

Hi @pmikova, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user pmikova" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[pmikova]

/covered

as I am currently employed by Red Hat

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

⚠️ @pmikova the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8208242-backport
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@pmikova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8208242: Add @requires to vmTestbase/gc/g1 tests

Added classunloading must not be disabled and G1 is required to g1/unloading tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• a15fa7a: 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah
• 29ec865: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X
• a7a9ea8: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS
• d8adeca: 8264526: javax/swing/text/html/parser/Parser/8078268/bug8078268.java timeout
• 1e99800: 8267246: -XX:MaxRAMPercentage=0 is unreasonable for jtreg tests on many-core machines
• 2221f37: 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS
• 0022605: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos
• 38a2505: 8256009: Remove src/hotspot/share/adlc/Test/i486.ad
• 299e6c8: 8256182: Update qemu-debootstrap cross-compilation recipe
• 3a35158: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
• ... and 12 more: https://git.openjdk.java.net/jdk11u-dev/compare/36e54fbd936cebfa8e66483d0daa4d22dcc3100a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (55b98003)

[pmikova]

/integrate

[openjdk]

@pmikova
Your change (at version 55b9800) is now ready to be sponsored by a Committer.

[shipilev]

Please make sure these configurations work as expected

• make test TEST=vmTestbase/gc/g1
• make test TEST=vmTestbase/gc/g1 TEST_VM_OPTS=-XX:+UseG1GC
• make test TEST=vmTestbase/gc/g1 TEST_VM_OPTS=-XX:+UseParallelGC (should skip all tests?)

[jerboaa]

Please make sure these configurations work as expected

* `make test TEST=vmTestbase/gc/g1`

* `make test TEST=vmTestbase/gc/g1 TEST_VM_OPTS=-XX:+UseG1GC`

* `make test TEST=vmTestbase/gc/g1 TEST_VM_OPTS=-XX:+UseParallelGC` (should skip all tests?)

s/make test/make run-test/g for JDK 11u?

[pmikova]

Please make sure these configurations work as expected

* `make test TEST=vmTestbase/gc/g1`

* `make test TEST=vmTestbase/gc/g1 TEST_VM_OPTS=-XX:+UseG1GC`

* `make test TEST=vmTestbase/gc/g1 TEST_VM_OPTS=-XX:+UseParallelGC` (should skip all tests?)

All mentioned configurations successfully passed, the last skipped the tests, as expected.

Thank you!

[shipilev]

All right then. There is a push approval (jdk11u-fix-yes) on the bug as well.

/sponsor

[openjdk]

Going to push as commit f8553d3.
Since your change was applied there have been 29 commits pushed to the master branch:

• 46d8523: 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed
• 6ec651f: 8276550: Use SHA256 hash in build.tools.depend.Depend
• e608a20: 8236596: HttpClient leaves HTTP/2 sockets in CLOSE_WAIT, when using proxy tunnel
• c6242ed: 8276854: Windows GHA builds fail due to broken Cygwin
• 1d62284: 8198617: java/awt/Focus/6382144/EndlessLoopTest.java fails on mac
• 2876be0: 8136517: [macosx]Test java/awt/Focus/8073453/AWTFocusTransitionTest.java fails on MacOSX
• c406da1: 8276943: Backout JDK-8274338 11u backport
• a15fa7a: 8274522: java/lang/management/ManagementFactory/MXBeanException.java test fails with Shenandoah
• 29ec865: 8171381: [TEST_BUG] [macos] javax/swing/JPopupMenu/7156657/bug7156657.java fails on OS X
• a7a9ea8: 8233562: [TESTBUG] Swing StyledEditorKit test bug4506788.java fails on MacOS
• ... and 19 more: https://git.openjdk.java.net/jdk11u-dev/compare/36e54fbd936cebfa8e66483d0daa4d22dcc3100a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @pmikova Pushed as commit f8553d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.