New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276201: Shenandoah: Race results degenerated GC to enter wrong entry point #612
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
@zhengyu123 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 35c045c.
Your commit was automatically rebased without conflicts. |
@zhengyu123 Pushed as commit 35c045c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a Shenandoah specific backport. It fixes a race that results degenerated GC to enter wrong degen entry point.
The original patch does not apply cleanly due to code divergence, especially the grand refactoring that is not in jdk11u. However, the backport is simple and straight forward.
Test:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/612/head:pull/612
$ git checkout pull/612
Update a local copy of the PR:
$ git checkout pull/612
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/612/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 612
View PR using the GUI difftool:
$ git pr show -t 612
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/612.diff