-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events #617
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think when you fix resolving in ProblemList.txt, there's a chance that the bots will recognize this backport as clean.
test/hotspot/jtreg/ProblemList.txt
Outdated
vmTestbase/nsk/jvmti/ThreadStart/threadstart003/TestDescription.java 8034084 generic-all | ||
======= | ||
vmTestbase/nsk/jvmti/scenarios/extension/EX03/ex03t001/TestDescription.java 8173658 generic-all | ||
>>>>>>> 14bb47410b... 8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That stuff does not look correctly resolved ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have a point there ... :)
ea733d5
to
48e2d43
Compare
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 3593e1e.
Your commit was automatically rebased without conflicts. |
I backport this test only fix as preparation for 8209611.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/617/head:pull/617
$ git checkout pull/617
Update a local copy of the PR:
$ git checkout pull/617
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/617/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 617
View PR using the GUI difftool:
$ git pr show -t 617
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/617.diff