Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events #617

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 11, 2021

I backport this test only fix as preparation for 8209611.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/617/head:pull/617
$ git checkout pull/617

Update a local copy of the PR:
$ git checkout pull/617
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/617/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 617

View PR using the GUI difftool:
$ git pr show -t 617

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/617.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 11, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 14bb47410bf27876e43229107334d97ad4851572 8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events Nov 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Nov 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 11, 2021

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

I think when you fix resolving in ProblemList.txt, there's a chance that the bots will recognize this backport as clean.

vmTestbase/nsk/jvmti/ThreadStart/threadstart003/TestDescription.java 8034084 generic-all
=======
vmTestbase/nsk/jvmti/scenarios/extension/EX03/ex03t001/TestDescription.java 8173658 generic-all
>>>>>>> 14bb47410b... 8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events
Copy link
Contributor

@RealCLanger RealCLanger Nov 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That stuff does not look correctly resolved ;-)

Copy link
Member Author

@GoeLin GoeLin Nov 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have a point there ... :)

@GoeLin GoeLin force-pushed the GoeLin-backport-14bb4741 branch from ea733d5 to 48e2d43 Compare Nov 15, 2021
@openjdk openjdk bot added the clean label Nov 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8034084: nsk.nsk/jvmti/ThreadStart/threadstart003  Wrong number of thread end events

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • f8553d3: 8208242: Add @requires to vmTestbase/gc/g1 tests
  • 46d8523: 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed
  • 6ec651f: 8276550: Use SHA256 hash in build.tools.depend.Depend
  • e608a20: 8236596: HttpClient leaves HTTP/2 sockets in CLOSE_WAIT, when using proxy tunnel

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 15, 2021
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Nov 16, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

Going to push as commit 3593e1e.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 9f7729a: 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows
  • 63848c5: 8201224: Make string buffer size dynamic in mlvmJvmtiUtils.c
  • 18f16db: 8174819: java/nio/file/WatchService/LotsOfEvents.java fails intermittently
  • 4b0cb20: 8204161: [TESTBUG] auto failed with the "Applet thread threw exception: java.lang.UnsupportedOperationException" exception
  • f8553d3: 8208242: Add @requires to vmTestbase/gc/g1 tests
  • 46d8523: 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed
  • 6ec651f: 8276550: Use SHA256 hash in build.tools.depend.Depend
  • e608a20: 8236596: HttpClient leaves HTTP/2 sockets in CLOSE_WAIT, when using proxy tunnel

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

@GoeLin Pushed as commit 3593e1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the GoeLin-backport-14bb4741 branch Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants