-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8265761: Font with missed font family name is not properly printed on Windows #62
Conversation
… Windows Reviewed-by: serb, prr
👋 Welcome back alexsch! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@AlexanderScherbatiy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 5a7e7d3.
Your commit was automatically rebased without conflicts. |
@AlexanderScherbatiy Pushed as commit 5a7e7d3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is the request to backport the fix to jdk 11u.
The patch applies cleanly to jdk11u-dev repository.
The
java/awt/print
andjava/awt/PrintJob
automated and manual tests were run with the fix.The automated tests pass.
The following manual tests fail with and without the fix:
Parse Exception: Arguments to manual option not supported: yesno:
Cannot access a member of class:
Can't find HTML file:
Does not have buttons on test dialog (pass, fail, ...)
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/62/head:pull/62
$ git checkout pull/62
Update a local copy of the PR:
$ git checkout pull/62
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/62/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 62
View PR using the GUI difftool:
$ git pr show -t 62
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/62.diff