Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly #621

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 12, 2021

Clean backport to fix x86_32 C2 bug.

Additional testing:

  • Linux x86_32 fastdebug tier1 passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/621/head:pull/621
$ git checkout pull/621

Update a local copy of the PR:
$ git checkout pull/621
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/621/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 621

View PR using the GUI difftool:
$ git pr show -t 621

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/621.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0488ebdf14dacfa79d98de16ed949c813dd88701 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 12, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Dec 1, 2021

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2021

Going to push as commit d2ed8cd.
Since your change was applied there have been 61 commits pushed to the master branch:

  • 596816e: 8268882: C2: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc
  • 1f885a1: 8272345: macos doesn't check os::set_boot_path() result
  • e0cb8fa: 8277796: Bump update version for OpenJDK: jdk-11.0.15
  • 22186cb: 8267256: Extend minimal retry for loopback connections on Windows to PlainSocketImpl
  • d92b103: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC
  • 5d99c71: 8255264: Support for identifying the full range of IPv4 localhost addresses on Windows
  • a412974: 8212148: Remove remaining NSK_CPP_STUBs
  • 2ea3786: 8236042: [TESTBUG] serviceability/sa/ClhsdbCDSCore.java fails with -Xcomp -XX:TieredStopAtLevel=1
  • 7f963ca: 8223400: Replace some enums with static const members in hotspot/runtime
  • 1aecb28: 8211899: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/scenarios/[E-M]
  • ... and 51 more: https://git.openjdk.java.net/jdk11u-dev/compare/6ec651fdc1c5ea0fe22731077446de1dd39cb24d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 1, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2021
@openjdk
Copy link

openjdk bot commented Dec 1, 2021

@shipilev Pushed as commit d2ed8cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8276105-c2-rounding branch Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant