Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32 #622

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 12, 2021

Clean backport to workaround x86_32 C2 compilation troubles.

Additional testing:

  • Linux x86_32 fastdebug tier1

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/622/head:pull/622
$ git checkout pull/622

Update a local copy of the PR:
$ git checkout pull/622
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/622/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 622

View PR using the GUI difftool:
$ git pr show -t 622

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/622.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 465d350d0b3cac277a58b9f8ece196c1cde68e80 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32 Nov 12, 2021
@openjdk
Copy link

openjdk bot commented Nov 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 12, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 12, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Nov 17, 2021

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 17, 2021

Going to push as commit 1b4eb43.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 0d0aa7c: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert
  • 394a5de: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • c2cda03: 8202342: [Graal] fromTonga/nsk/jvmti/unit/FollowReferences/followref003/TestDescription.java fails with "Location mismatch" errors
  • 35c045c: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • 3593e1e: 8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events
  • 9f7729a: 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows
  • 63848c5: 8201224: Make string buffer size dynamic in mlvmJvmtiUtils.c
  • 18f16db: 8174819: java/nio/file/WatchService/LotsOfEvents.java fails intermittently
  • 4b0cb20: 8204161: [TESTBUG] auto failed with the "Applet thread threw exception: java.lang.UnsupportedOperationException" exception
  • f8553d3: 8208242: Add @requires to vmTestbase/gc/g1 tests
  • ... and 1 more: https://git.openjdk.java.net/jdk11u-dev/compare/6ec651fdc1c5ea0fe22731077446de1dd39cb24d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 17, 2021
@openjdk
Copy link

openjdk bot commented Nov 17, 2021

@shipilev Pushed as commit 1b4eb43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8276157-c2-32bit-stackoverflow branch Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant