Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows #623

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 14, 2021

Backport of JDK-8258457

Mostly clean. Change to problemlist is not relevant for 11u. I also had to resolve copyright header update.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/623/head:pull/623
$ git checkout pull/623

Update a local copy of the PR:
$ git checkout pull/623
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/623/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 623

View PR using the GUI difftool:
$ git pr show -t 623

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/623.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 14, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 40ef00cebf69acaec2a81f7b689a1af2cc2a8ad1 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows Nov 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 14, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Nov 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 14, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Nov 14, 2021

GHA failure is not related to this backport. It's an intermittent failure that I've seen already a few times.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f8553d3: 8208242: Add @requires to vmTestbase/gc/g1 tests
  • 46d8523: 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 15, 2021
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Nov 15, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

Going to push as commit 9f7729a.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 63848c5: 8201224: Make string buffer size dynamic in mlvmJvmtiUtils.c
  • 18f16db: 8174819: java/nio/file/WatchService/LotsOfEvents.java fails intermittently
  • 4b0cb20: 8204161: [TESTBUG] auto failed with the "Applet thread threw exception: java.lang.UnsupportedOperationException" exception
  • f8553d3: 8208242: Add @requires to vmTestbase/gc/g1 tests
  • 46d8523: 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

@RealCLanger Pushed as commit 9f7729a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-40ef00ce branch Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants