Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250521: Configure initial RTO to use minimal retry for loopback connections on Windows #626

Closed
wants to merge 1 commit into from

Conversation

macarte
Copy link
Contributor

@macarte macarte commented Nov 15, 2021

Backport of JDK-8250521


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8250521: Configure initial RTO to use minimal retry for loopback connections on Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/626/head:pull/626
$ git checkout pull/626

Update a local copy of the PR:
$ git checkout pull/626
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 626

View PR using the GUI difftool:
$ git pr show -t 626

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/626.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 15, 2021

👋 Welcome back macarte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c2fa441d8ded94241fdac7005d6420f99b38af0b 8250521: Configure initial RTO to use minimal retry for loopback connections on Windows Nov 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 15, 2021

@macarte This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8250521: Configure initial RTO to use minimal retry for loopback connections on Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

  • 19a1969: 8274773: [TESTBUG] UnsafeIntrinsicsTest intermittently fails on weak memory model platform
  • e59323f: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
  • 48b5a6a: 8277815: Fix mistakes in legal header backports
  • 87c04f2: 8211801: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/scenarios/[A-E]
  • 84a3397: 8211905: Remove multiple casts for EM06 file
  • 91c6420: 8211131: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/[G-I]*
  • 0b8e1b1: 8211261: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/[A-G]*
  • a7f1b72: 8210984: [TESTBUG] hs203t003 fails with "# ERROR: hs203t003.cpp, 218: NSK_CPP_STUB2 ( ResumeThread, jvmti, thread)"
  • 6d1c3c6: 8210689: Remove the multi-line old C style for string literals
  • 9a1fce0: 8210726: Fix up a few minor nits forgotten by JDK-8210665
  • ... and 24 more: https://git.openjdk.java.net/jdk11u-dev/compare/35c045c36327198375c4fe0ac32af7035643dc12...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Nov 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 15, 2021

Webrevs

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 16, 2021

Hi Mat,
I suggest you "git rebase" your backport branch to current master. Then it'll look clean. No need for merges as nothing was reivewed or so...

@macarte
Copy link
Contributor Author

@macarte macarte commented Nov 26, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

@macarte
Your change (at version 0e76be1) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 26, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

Going to push as commit b6a9e7e.
Since your change was applied there have been 35 commits pushed to the master branch:

  • 7bdb8ac: 8248238: Implementation: JEP 388: Windows AArch64 Support
  • 19a1969: 8274773: [TESTBUG] UnsafeIntrinsicsTest intermittently fails on weak memory model platform
  • e59323f: 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE
  • 48b5a6a: 8277815: Fix mistakes in legal header backports
  • 87c04f2: 8211801: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/scenarios/[A-E]
  • 84a3397: 8211905: Remove multiple casts for EM06 file
  • 91c6420: 8211131: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/[G-I]*
  • 0b8e1b1: 8211261: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/[A-G]*
  • a7f1b72: 8210984: [TESTBUG] hs203t003 fails with "# ERROR: hs203t003.cpp, 218: NSK_CPP_STUB2 ( ResumeThread, jvmti, thread)"
  • 6d1c3c6: 8210689: Remove the multi-line old C style for string literals
  • ... and 25 more: https://git.openjdk.java.net/jdk11u-dev/compare/35c045c36327198375c4fe0ac32af7035643dc12...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

@RealCLanger @macarte Pushed as commit b6a9e7e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants