Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266480: Implicit null check optimization does not update control of hoisted memory operation #63

Closed
wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 24, 2021

JDK-8266480 should get backported for parity with 11.0.13-oracle. Applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266480: Implicit null check optimization does not update control of hoisted memory operation

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/63/head:pull/63
$ git checkout pull/63

Update a local copy of the PR:
$ git checkout pull/63
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/63/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 63

View PR using the GUI difftool:
$ git pr show -t 63

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/63.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c2b50f93ac36cdfd96d3ed09ec80ee5255a10200 8266480: Implicit null check optimization does not update control of hoisted memory operation Jun 24, 2021
@openjdk
Copy link

openjdk bot commented Jun 24, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266480: Implicit null check optimization does not update control of hoisted memory operation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 25, 2021

Going to push as commit f56d1f6.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 2c2cc74: 8261496: Shenandoah: reconsider pacing updates memory ordering
  • a092a17: 8266813: Shenandoah: Use shorter instruction sequence for checking if marking in progress
  • 80a72de: 8266018: Shenandoah: fix an incorrect assert
  • a0958a8: 8210959: JShell fails and exits when statement throws an exception whose message contains a '%'.
  • 66d4ee9: 8247421: [TESTBUG] ReturnBlobToWrongHeapTest.java failed allocating blob
  • df587c7: 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M
  • c39f3f7: 8193214: Incorrect annotations.without.processors warnings with JDK 9
  • 34d1c92: 8231717: Improve performance of charset decoding when charset is always compactable

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 25, 2021
@openjdk
Copy link

openjdk bot commented Jun 25, 2021

@TheRealMDoerr Pushed as commit f56d1f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8266480_C2 branch June 25, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant