Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert #631

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Nov 16, 2021

Clean backport to improve tests and CA store.

Additional testing:

  • Linux x86_64 fastdebug jdk/security passes
  • Linux x86_64 fastdebug java/security passes
  • Linux x86_64 fastdebug VerifyCA passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/631/head:pull/631
$ git checkout pull/631

Update a local copy of the PR:
$ git checkout pull/631
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/631/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 631

View PR using the GUI difftool:
$ git pr show -t 631

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/631.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 16, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4bc9b049846bd59f5c41bd62a59b567b52c9efc5 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert Nov 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3593e1e: 8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 16, 2021

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Nov 17, 2021

Got the push approval.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

Going to push as commit 0d0aa7c.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 394a5de: 8253147: The javax/swing/JPopupMenu/7154841/bug7154841.java fail on big screens
  • c2cda03: 8202342: [Graal] fromTonga/nsk/jvmti/unit/FollowReferences/followref003/TestDescription.java fails with "Location mismatch" errors
  • 35c045c: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • 3593e1e: 8034084: nsk.nsk/jvmti/ThreadStart/threadstart003 Wrong number of thread end events

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 17, 2021

@shipilev Pushed as commit 0d0aa7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8263059-comodo-ca branch Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant