Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit #633

Closed

Conversation

adamfarley
Copy link

@adamfarley adamfarley commented Nov 16, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/633/head:pull/633
$ git checkout pull/633

Update a local copy of the PR:
$ git checkout pull/633
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/633/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 633

View PR using the GUI difftool:
$ git pr show -t 633

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/633.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 16, 2021

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fc0fe256793b33430c1247e0c091150a091da3c4 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit Nov 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 16, 2021

@adamfarley This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 2fb8ca2: 8273026: Slow LoginContext.login() on multi threading application
  • e2b7f1e: 8210198: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[A-F] tests
  • 770a78a: 8210182: Remove macros for C compilation from vmTestBase but non jvmti
  • 63277a4: 8226943: compile error in libfollowref003.cpp with XCode 10.2 on macosx
  • 4b591db: 8209611: use C++ compiler for hotspot tests
  • 5e08548: 8274860: gcc 10.2.1 produces an uninitialized warning in sharedRuntimeTrig.cpp
  • 9b94409: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
  • ed9a41b: 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766
  • ccd7a6f: 8275766: (tz) Update Timezone Data to 2021e
  • d9b2c4c: 8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64
  • ... and 4 more: https://git.openjdk.java.net/jdk11u-dev/compare/35c045c36327198375c4fe0ac32af7035643dc12...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Nov 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 16, 2021

Webrevs

@adamfarley
Copy link
Author

@adamfarley adamfarley commented Nov 23, 2021

/integrate

@adamfarley
Copy link
Author

@adamfarley adamfarley commented Nov 23, 2021

Bug now has the "jdk11u-fix-yes" tag. Sponsor requested please.

@openjdk openjdk bot added the sponsor label Nov 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

@adamfarley
Your change (at version c392bbd) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

@phohensee phohensee commented Nov 23, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

Going to push as commit dcc010d.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 2fb8ca2: 8273026: Slow LoginContext.login() on multi threading application
  • e2b7f1e: 8210198: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[A-F] tests
  • 770a78a: 8210182: Remove macros for C compilation from vmTestBase but non jvmti
  • 63277a4: 8226943: compile error in libfollowref003.cpp with XCode 10.2 on macosx
  • 4b591db: 8209611: use C++ compiler for hotspot tests
  • 5e08548: 8274860: gcc 10.2.1 produces an uninitialized warning in sharedRuntimeTrig.cpp
  • 9b94409: 8277029: JMM GetDiagnosticXXXInfo APIs should verify output array sizes
  • ed9a41b: 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766
  • ccd7a6f: 8275766: (tz) Update Timezone Data to 2021e
  • d9b2c4c: 8256956: RegisterImpl::max_slots_per_register is incorrect on AMD64
  • ... and 4 more: https://git.openjdk.java.net/jdk11u-dev/compare/35c045c36327198375c4fe0ac32af7035643dc12...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 23, 2021

@phohensee @adamfarley Pushed as commit dcc010d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@adamfarley
Copy link
Author

@adamfarley adamfarley commented Nov 24, 2021

Thanks Paul. +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants