Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260282: Add option to compress heap dumps created by -XX:+HeapDumpOnOutOfMemoryError #640

Closed
wants to merge 1 commit into from

Conversation

schmelter-sap
Copy link
Contributor

@schmelter-sap schmelter-sap commented Nov 18, 2021

Add option to compress heap dumps created by -XX:+HeapDumpOnOutOfMemoryError

The change itself had to be slightly modified, since VM arguments are declared slightly different in JDK11 (the MANAGABLE flag is not supported). Otherwise no adjustments were needed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260282: Add option to compress heap dumps created by -XX:+HeapDumpOnOutOfMemoryError

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/640/head:pull/640
$ git checkout pull/640

Update a local copy of the PR:
$ git checkout pull/640
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/640/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 640

View PR using the GUI difftool:
$ git pr show -t 640

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/640.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 18, 2021

👋 Welcome back rschmelter! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d2b0ea1d01a0628065115a0f163ff763ad70296e 8260282: Add option to compress heap dumps created by -XX:+HeapDumpOnOutOfMemoryError Nov 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 18, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Nov 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 18, 2021

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

LGTM. Thanks for backporting!

@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2021

@schmelter-sap This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8260282: Add option to compress heap dumps created by -XX:+HeapDumpOnOutOfMemoryError

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 19, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 17, 2021

@schmelter-sap This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 15, 2022

@schmelter-sap This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready rfr
2 participants