Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8210429: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[G-Z] tests #644

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 22, 2021

I backport this for parity with 11.0.14-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8210429: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[G-Z] tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/644/head:pull/644
$ git checkout pull/644

Update a local copy of the PR:
$ git checkout pull/644
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/644/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 644

View PR using the GUI difftool:
$ git pr show -t 644

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/644.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d90f0a51c258a16bbe51f65579dbd5dbb9b18594 8210429: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[G-Z] tests Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210429: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[G-Z] tests

Remove the JNI_ENV_ARG for the rest of the Get[G-Z]

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2021

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Nov 24, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

Going to push as commit 46c41b6.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 06e9f96: 8210242: [TESTBUG] vmTestbase/nsk/stress/jni/jnistress001.java crashes with EXCEPTION_ACCESS_VIOLATION on windows-x86
  • dcc010d: 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit
  • 2fb8ca2: 8273026: Slow LoginContext.login() on multi threading application
  • e2b7f1e: 8210198: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[A-F] tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@GoeLin Pushed as commit 46c41b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant