Skip to content

Conversation

@zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Nov 22, 2021

A clean backport for parity with Oracle 11.0.15.

The patch fixed potential crash in test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8210242: [TESTBUG] vmTestbase/nsk/stress/jni/jnistress001.java crashes with EXCEPTION_ACCESS_VIOLATION on windows-x86

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/649/head:pull/649
$ git checkout pull/649

Update a local copy of the PR:
$ git checkout pull/649
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/649/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 649

View PR using the GUI difftool:
$ git pr show -t 649

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/649.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3837f1abc10bb0fc1662feea2251a84af2903970 8210242: [TESTBUG] vmTestbase/nsk/stress/jni/jnistress001.java crashes with EXCEPTION_ACCESS_VIOLATION on windows-x86 Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210242: [TESTBUG] vmTestbase/nsk/stress/jni/jnistress001.java crashes with EXCEPTION_ACCESS_VIOLATION on windows-x86

Non-NUL-terminated string was passed to %s - use %.*s to specify the actual length.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2021

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@zhengyu123
Copy link
Contributor Author

Got approval, integrated

@openjdk
Copy link

openjdk bot commented Nov 23, 2021

Going to push as commit 06e9f96.
Since your change was applied there have been 3 commits pushed to the master branch:

  • dcc010d: 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit
  • 2fb8ca2: 8273026: Slow LoginContext.login() on multi threading application
  • e2b7f1e: 8210198: Clean up JNI_ENV_ARG for vmTestbase/jvmti/Get[A-F] tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@zhengyu123 Pushed as commit 06e9f96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant