Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8202142: jfr/event/io/TestInstrumentation is unstable #653

Closed
wants to merge 2 commits into from

Conversation

dongbohe
Copy link
Member

@dongbohe dongbohe commented Nov 24, 2021

Fix jdk/jfr/event/io/TestInstrumentation.java and remove it from ProblemList.txt.

There are only context and copyright conflicts, which have been resolved manually

Test: jdk/jfr/event/io/TestInstrumentation.java passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8202142: jfr/event/io/TestInstrumentation is unstable

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/653/head:pull/653
$ git checkout pull/653

Update a local copy of the PR:
$ git checkout pull/653
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/653/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 653

View PR using the GUI difftool:
$ git pr show -t 653

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/653.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2021

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0b9ff0c3a418070996f61f69165de02d33070f7f 8202142: jfr/event/io/TestInstrumentation is unstable Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 24, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2021

Webrevs

@dongbohe
Copy link
Member Author

ping?

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Dec 16, 2021

@dongbohe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8202142: jfr/event/io/TestInstrumentation is unstable

Reviewed-by: phh, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

  • 4b68145: Merge
  • d665a4e: 8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint
  • 90c933e: 8207793: [TESTBUG] runtime/Metaspace/FragmentMetaspace.java fails: heap needs to be increased
  • 9363d55: 8211170: AArch64: Warnings in C1 and template interpreter
  • c94151b: 8273575: memory leak in appendBootClassPath(), paths must be deallocated
  • ba1a0e8: 8266187: Memory leak in appendBootClassPath()
  • c8c546b: 8240904: Screen flashes on test failures when running tests from make
  • b77a165: 8234930: Use MAP_JIT when allocating pages for code cache on macOS
  • 9bc99d8: 8275811: Incorrect instance to dispose
  • 180fbf0: 8186780: clang fastdebug assertion failure in os_linux_x86:os::verify_stack_alignment()
  • ... and 70 more: https://git.openjdk.java.net/jdk11u-dev/compare/2fb8ca2b2f4c9259446e9b17c5ba446c18c80b28...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @Hamlin-Li) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2021
@dongbohe
Copy link
Member Author

Thank you for your review, Paul.

@dongbohe
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 17, 2021
@openjdk
Copy link

openjdk bot commented Dec 17, 2021

@dongbohe
Your change (at version d389308) is now ready to be sponsored by a Committer.

@Hamlin-Li
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 17, 2021

Going to push as commit 86c2995.
Since your change was applied there have been 80 commits pushed to the master branch:

  • 4b68145: Merge
  • d665a4e: 8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint
  • 90c933e: 8207793: [TESTBUG] runtime/Metaspace/FragmentMetaspace.java fails: heap needs to be increased
  • 9363d55: 8211170: AArch64: Warnings in C1 and template interpreter
  • c94151b: 8273575: memory leak in appendBootClassPath(), paths must be deallocated
  • ba1a0e8: 8266187: Memory leak in appendBootClassPath()
  • c8c546b: 8240904: Screen flashes on test failures when running tests from make
  • b77a165: 8234930: Use MAP_JIT when allocating pages for code cache on macOS
  • 9bc99d8: 8275811: Incorrect instance to dispose
  • 180fbf0: 8186780: clang fastdebug assertion failure in os_linux_x86:os::verify_stack_alignment()
  • ... and 70 more: https://git.openjdk.java.net/jdk11u-dev/compare/2fb8ca2b2f4c9259446e9b17c5ba446c18c80b28...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 17, 2021
@openjdk openjdk bot closed this Dec 17, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 17, 2021
@openjdk
Copy link

openjdk bot commented Dec 17, 2021

@Hamlin-Li @dongbohe Pushed as commit 86c2995.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants