Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261496: Shenandoah: reconsider pacing updates memory ordering #66

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Jun 25, 2021

This backport does not apply cleanly, because the Atomic parameter orders had changed since JDK-8234563. Passes hotspot_gc_shenandoah.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261496: Shenandoah: reconsider pacing updates memory ordering

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/66/head:pull/66
$ git checkout pull/66

Update a local copy of the PR:
$ git checkout pull/66
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/66/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 66

View PR using the GUI difftool:
$ git pr show -t 66

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/66.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 25, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 4642730b057bfa37df740fc8d9e17bfb60e53447 8261496: Shenandoah: reconsider pacing updates memory ordering Jun 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 25, 2021

Webrevs

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jun 25, 2021

Got the push approval.

/integrate

Loading

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Approving when @rkennke approves 😄 I think we have to vote him up as official jdk-updates-reviewer.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261496: Shenandoah: reconsider pacing updates memory ordering

Reviewed-by: rkennke, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • a092a17: 8266813: Shenandoah: Use shorter instruction sequence for checking if marking in progress
  • 80a72de: 8266018: Shenandoah: fix an incorrect assert
  • a0958a8: 8210959: JShell fails and exits when statement throws an exception whose message contains a '%'.
  • 66d4ee9: 8247421: [TESTBUG] ReturnBlobToWrongHeapTest.java failed allocating blob

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

Going to push as commit 2c2cc74.
Since your change was applied there have been 4 commits pushed to the master branch:

  • a092a17: 8266813: Shenandoah: Use shorter instruction sequence for checking if marking in progress
  • 80a72de: 8266018: Shenandoah: fix an incorrect assert
  • a0958a8: 8210959: JShell fails and exits when statement throws an exception whose message contains a '%'.
  • 66d4ee9: 8247421: [TESTBUG] ReturnBlobToWrongHeapTest.java failed allocating blob

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

@shipilev Pushed as commit 2c2cc74.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8261496 branch Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants