Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big #672

Closed
wants to merge 2 commits into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Nov 29, 2021

Hi,

trivial backport of 8261661: "gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big"

Did not apply cleanly due to copyright header changes.

Cheers, Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/672/head:pull/672
$ git checkout pull/672

Update a local copy of the PR:
$ git checkout pull/672
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/672/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 672

View PR using the GUI difftool:
$ git pr show -t 672

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/672.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 735757f1e0ec9d05eb4c6f4d680b34de96f83700 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big Nov 29, 2021
@openjdk
Copy link

openjdk bot commented Nov 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 29, 2021
@tstuefe tstuefe marked this pull request as ready for review November 29, 2021 08:24
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2021

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But... the copyright line conflict means we need to add "2021" from the original patch?

@tstuefe
Copy link
Member Author

tstuefe commented Nov 29, 2021

But... the copyright line conflict means we need to add "2021" from the original patch?

Okay, I was not clear on that. Will change.

@openjdk
Copy link

openjdk bot commented Nov 29, 2021

@tstuefe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2021
@tstuefe
Copy link
Member Author

tstuefe commented Nov 29, 2021

Thanks, @shipilev .

Meanwhile, I got approval in JBS.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 29, 2021

Going to push as commit 48dbaf1.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 242bbef: 8270290: NTLM authentication fails if HEAD request is used

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 29, 2021
@openjdk
Copy link

openjdk bot commented Nov 29, 2021

@tstuefe Pushed as commit 48dbaf1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants