Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c #678

Closed
wants to merge 1 commit into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Nov 30, 2021

Applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/678/head:pull/678
$ git checkout pull/678

Update a local copy of the PR:
$ git checkout pull/678
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/678/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 678

View PR using the GUI difftool:
$ git pr show -t 678

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/678.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2021

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 39abac98f9803897e40c32d5bcb35bd25c348d2a 8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c Nov 30, 2021
@openjdk
Copy link

openjdk bot commented Nov 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 30, 2021

@phohensee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266176: -Wmaybe-uninitialized happens in libArrayIndexOutOfBoundsExceptionTest.c

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 596816e: 8268882: C2: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 30, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2021

Webrevs

@phohensee
Copy link
Member Author

phohensee commented Dec 1, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2021

Going to push as commit 12ffc99.
Since your change was applied there have been 4 commits pushed to the master branch:

  • a0c349b: 8274265: Suspicious string concatenation in logTestUtils.inline.hpp
  • 35964ca: 8222825: ARM32 SIGILL issue on single core CPU (not supported PLDW instruction)
  • d2ed8cd: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • 596816e: 8268882: C2: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 1, 2021
@openjdk
Copy link

openjdk bot commented Dec 1, 2021

@phohensee Pushed as commit 12ffc99.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@phohensee phohensee deleted the backport-39abac98 branch Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant