Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274265: Suspicious string concatenation in logTestUtils.inline.hpp #679

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 1, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274265: Suspicious string concatenation in logTestUtils.inline.hpp

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/679/head:pull/679
$ git checkout pull/679

Update a local copy of the PR:
$ git checkout pull/679
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/679/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 679

View PR using the GUI difftool:
$ git pr show -t 679

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/679.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 1, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c57a6c62baecde0bc10bfca89e0616b0c1fbb714 8274265: Suspicious string concatenation in logTestUtils.inline.hpp Dec 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2021

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274265: Suspicious string concatenation in logTestUtils.inline.hpp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Dec 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 1, 2021

Webrevs

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Dec 1, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2021

Going to push as commit a0c349b.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 35964ca: 8222825: ARM32 SIGILL issue on single core CPU (not supported PLDW instruction)
  • d2ed8cd: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 1, 2021

@MBaesken Pushed as commit a0c349b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant