Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266168: -Wmaybe-uninitialized happens in check_code.c #682

Closed
wants to merge 1 commit into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Dec 2, 2021

Applies cleanly net of copyright date update conflict.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8266168: -Wmaybe-uninitialized happens in check_code.c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/682/head:pull/682
$ git checkout pull/682

Update a local copy of the PR:
$ git checkout pull/682
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/682/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 682

View PR using the GUI difftool:
$ git pr show -t 682

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/682.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2021

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0f9852c63b12c43b52615ea003a4fc1d69ad3ada 8266168: -Wmaybe-uninitialized happens in check_code.c Dec 2, 2021
@openjdk
Copy link

openjdk bot commented Dec 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 2, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2021

Webrevs

@phohensee
Copy link
Member Author

/clean

@openjdk openjdk bot added the clean label Dec 2, 2021
@openjdk
Copy link

openjdk bot commented Dec 2, 2021

@phohensee This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Dec 2, 2021

@phohensee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266168: -Wmaybe-uninitialized happens in check_code.c

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2021
@phohensee
Copy link
Member Author

/integrate

Got approval.

@openjdk
Copy link

openjdk bot commented Dec 6, 2021

Going to push as commit 3a452af.
Since your change was applied there have been 2 commits pushed to the master branch:

  • c82d66c: 8266174: -Wmisleading-indentation happens in libmlib_image sources
  • f8ed0fe: 8251558: J2DBench should support shaped and translucent windows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2021
@openjdk
Copy link

openjdk bot commented Dec 6, 2021

@phohensee Pushed as commit 3a452af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@phohensee phohensee deleted the backport-0f9852c6 branch December 6, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant