Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256373: [Windows/HiDPI] The Frame#setBounds does not work in a minimized state #683

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 5, 2021

Hi all,

This pull request contains a backport of commit b5ce8af3 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 1 Dec 2020 and was reviewed by Alexander Zuev and Alexey Ivanov.

The new test passed, no new issue in the jdk_desktop test group on the system where the bug was reproduced.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8256373: [Windows/HiDPI] The Frame#setBounds does not work in a minimized state

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/683/head:pull/683
$ git checkout pull/683

Update a local copy of the PR:
$ git checkout pull/683
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/683/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 683

View PR using the GUI difftool:
$ git pr show -t 683

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/683.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b5ce8af3d7f991c0cea7b2380469fd30f3030670 8256373: [Windows/HiDPI] The Frame#setBounds does not work in a minimized state Dec 5, 2021
@openjdk
Copy link

openjdk bot commented Dec 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 5, 2021

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256373: [Windows/HiDPI] The Frame#setBounds does not work in a minimized state

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 3a452af: 8266168: -Wmaybe-uninitialized happens in check_code.c
  • c82d66c: 8266174: -Wmisleading-indentation happens in libmlib_image sources
  • f8ed0fe: 8251558: J2DBench should support shaped and translucent windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2021
@mrserb mrserb marked this pull request as ready for review December 6, 2021 22:45
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 6, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2021

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Dec 8, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2021

Going to push as commit eb2a92f.
Since your change was applied there have been 5 commits pushed to the master branch:

  • d0445aa: 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah
  • 38bfb43: 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException
  • 3a452af: 8266168: -Wmaybe-uninitialized happens in check_code.c
  • c82d66c: 8266174: -Wmisleading-indentation happens in libmlib_image sources
  • f8ed0fe: 8251558: J2DBench should support shaped and translucent windows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2021
@openjdk
Copy link

openjdk bot commented Dec 8, 2021

@mrserb Pushed as commit eb2a92f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant