Skip to content

8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 6, 2021

I backport this for parity with 11.0.15-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/688/head:pull/688
$ git checkout pull/688

Update a local copy of the PR:
$ git checkout pull/688
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 688

View PR using the GUI difftool:
$ git pr show -t 688

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/688.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fe7d70886cc9985478c5810eff0790648a9aae41 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong Dec 6, 2021
@openjdk
Copy link

openjdk bot commented Dec 6, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 6, 2021
@GoeLin
Copy link
Member Author

GoeLin commented Dec 6, 2021

I had to resolve the copyrights and the test specification.
I turned it into the standard syntax as used in head.

@mlbridge
Copy link

mlbridge bot commented Dec 6, 2021

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • d0445aa: 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah
  • 38bfb43: 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException
  • 3a452af: 8266168: -Wmaybe-uninitialized happens in check_code.c
  • c82d66c: 8266174: -Wmisleading-indentation happens in libmlib_image sources

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2021
@GoeLin
Copy link
Member Author

GoeLin commented Dec 9, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 9, 2021

Going to push as commit eaa4197.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 15f3e0e: 8255035: Update BCEL to Version 6.5.0
  • c3aaef3: 8257769: Cipher.getParameters() throws NPE for ChaCha20-Poly1305
  • 9bf52e6: 8233827: Enable screenshots in the enhanced failure handler on Linux/macOS
  • 4beb4ad: 8210236: Prepare ciReceiverTypeData::translate_receiver_data_from for concurrent class unloading
  • 8878ffc: 8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12
  • 554498d: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable
  • 9b96ac9: Merge
  • f5664ea: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside
  • 8fe5d59: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie
  • eb2a92f: 8256373: [Windows/HiDPI] The Frame#setBounds does not work in a minimized state
  • ... and 4 more: https://git.openjdk.java.net/jdk11u-dev/compare/f8ed0fecfd7d8f2fde6b18752b84f2175e50fa65...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2021
@GoeLin GoeLin deleted the goetz_backport_8272473 branch December 9, 2021 11:38
@openjdk
Copy link

openjdk bot commented Dec 9, 2021

@GoeLin Pushed as commit eaa4197.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants