Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint #692

Closed
wants to merge 1 commit into from

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Dec 7, 2021

Almost clean backport to jdk11u-dev.
only one piece of patch failed to apply cleanly in loopPredicate.cpp due to difference in context code
the included testcase fails before patch and passes after. Additional testing: tier1 by GHA, tier2.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/692/head:pull/692
$ git checkout pull/692

Update a local copy of the PR:
$ git checkout pull/692
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 692

View PR using the GUI difftool:
$ git pr show -t 692

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/692.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 01cb2b9883d7c9ecdba0ee5bd42124faed4d080c 8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint Dec 7, 2021
@openjdk
Copy link

openjdk bot commented Dec 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 7, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2021

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Lgtm.

@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d0445aa: 8274523: java/lang/management/MemoryMXBean/MemoryTest.java test should handle Shenandoah
  • 38bfb43: 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2021
@VladimirKempik
Copy link
Author

VladimirKempik commented Dec 8, 2021

There is now a openjdk/jdk11u#21 from @TheRealMDoerr

@VladimirKempik
Copy link
Author

VladimirKempik commented Dec 9, 2021

Withdrawn as PR to jdk11u was approved first

@VladimirKempik VladimirKempik deleted the JDK-8277529 branch Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants