Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable #697

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Dec 7, 2021

Basically clean backport of JDK-8199079. I only had to remove the test from the problem list manually due to different context.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/697/head:pull/697
$ git checkout pull/697

Update a local copy of the PR:
$ git checkout pull/697
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/697/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 697

View PR using the GUI difftool:
$ git pr show -t 697

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/697.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@TheRealMDoerr TheRealMDoerr changed the title 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable Backport 41fc7ddd8d3e2a8408cc96cf3c95ce89166cd9c9 Dec 7, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2021
@openjdk openjdk bot changed the title Backport 41fc7ddd8d3e2a8408cc96cf3c95ce89166cd9c9 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable Dec 7, 2021
@openjdk
Copy link

openjdk bot commented Dec 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport and removed rfr Pull request is ready for review labels Dec 7, 2021
@TheRealMDoerr TheRealMDoerr changed the title 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable Dec 7, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 7, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

Note: There was a tab in the headline in the original bug. I fixed it there and then updated this PR title.

@openjdk
Copy link

openjdk bot commented Dec 8, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • eb2a92f: 8256373: [Windows/HiDPI] The Frame#setBounds does not work in a minimized state

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2021
@TheRealMDoerr
Copy link
Contributor Author

Thanks for reviewing and the approval!
/integrate

@openjdk
Copy link

openjdk bot commented Dec 9, 2021

Going to push as commit 554498d.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 9b96ac9: Merge
  • f5664ea: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside
  • 8fe5d59: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie
  • eb2a92f: 8256373: [Windows/HiDPI] The Frame#setBounds does not work in a minimized state

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2021
@TheRealMDoerr TheRealMDoerr deleted the 8199079_swing_testbug branch December 9, 2021 09:54
@openjdk
Copy link

openjdk bot commented Dec 9, 2021

@TheRealMDoerr Pushed as commit 554498d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants