8253639: Change os::attempt_reserve_memory_at parameter order

[phohensee]

This is a pre-requisite to the 11u backport of JDK-8255254, see #578.

No semantic changes, just a parameter reorder.

Applies cleanly net of context, patching os_solaris.cpp in the same manner as os_linux.cpp, and eliminating the original patch's change to split_reserved_memory in os_windows.cpp since attempt_reserve_memory_at is unused therein for 11u.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253639: Change os::attempt_reserve_memory_at parameter order

Reviewers

• Vladimir Kempik (@VladimirKempik - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/699/head:pull/699
$ git checkout pull/699

Update a local copy of the PR:
$ git checkout pull/699
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/699/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 699

View PR using the GUI difftool:
$ git pr show -t 699

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/699.diff

[bridgekeeper]

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (32e5cf7e)

[VladimirKempik]

Hello, have you tried to build solaris ( at least the hotspot) with the patch to make sure everything is still ok there ?
I have triggered solaris builds in our infra to check that.

[VladimirKempik]

Hotspot on solaris still can be built with these patches

[VladimirKempik]

I now doubt it should be pushed to jdk11u. check this comment - #580 (comment)

[phohensee]

Closing due to maintainer preference, see #578.