Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267695: Bump update version for OpenJDK: jdk-11.0.13 #7

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 2, 2021

Change to bump the version to 11.0.13 and to update .jcheck/conf.

That is needed so that JBS annotates the right version when closing changes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267695: Bump update version for OpenJDK: jdk-11.0.13 ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/7/head:pull/7
$ git checkout pull/7

Update a local copy of the PR:
$ git checkout pull/7
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/7/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 7

View PR using the GUI difftool:
$ git pr show -t 7

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/7.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 2, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2021

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267695: Bump update version for OpenJDK: jdk-11.0.13

Reviewed-by: sgehwolf, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2d76828: 8267695: Bump update version for OpenJDK: jdk-11.0.13

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 2, 2021
@jerboaa
Copy link
Contributor

jerboaa commented Jun 2, 2021

@edvbld @rwestberg Any idea why I show up as "Committer" in the "Reviewers" section of this issue added by the bots? Shouldn't that be "Reviewer"? See:
https://openjdk.java.net/census#sgehwolf

@kevinrushforth
Copy link
Member

@jerboaa This is because the current version of .jcheck/conf is incorrectly pointing to the jdk10 project, in which you are a Committer, and not the jdk-updates project. Once this PR is integrated you should no longer see this problem.

@jerboaa
Copy link
Contributor

jerboaa commented Jun 2, 2021

@kevinrushforth Thanks! That clears things up. Much appreciated!

@jerboaa
Copy link
Contributor

jerboaa commented Jun 2, 2021

@GoeLin Since this has been pushed with 2d76828 please close this PR.

@GoeLin GoeLin closed this Jun 2, 2021
@GoeLin GoeLin deleted the 8267695-version_11.0.13_and_jcheck branch June 30, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

4 participants