Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267348: Rewrite gc/epsilon/TestClasses.java to use Metaspace with less classes #70

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Jun 25, 2021

Unclean backport, because the test is in old package (thus need to drop gc.epsilon package). Passes gc/epsilon.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267348: Rewrite gc/epsilon/TestClasses.java to use Metaspace with less classes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/70/head:pull/70
$ git checkout pull/70

Update a local copy of the PR:
$ git checkout pull/70
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/70/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 70

View PR using the GUI difftool:
$ git pr show -t 70

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/70.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 25, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 7b98400c81900a8c779394d549b5fb61f1dd8638 8267348: Rewrite gc/epsilon/TestClasses.java to use Metaspace with less classes Jun 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 25, 2021

Webrevs

Loading

Copy link
Contributor

@RealCLanger RealCLanger left a comment

LGTM

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267348: Rewrite gc/epsilon/TestClasses.java to use Metaspace with less classes

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

  • d7a6e51: 8253899: Make IsClassUnloadingEnabled signature match specification
  • 293d44f: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 2a3d908: 8269661: JNI_GetStringCritical does not lock char array
  • 6762216: 8267666: Add option to jcmd GC.heap_dump to use existing file
  • 63c4ec2: 8259535: ECDSA SignatureValue do not always have the specified length
  • 133eca0: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
  • 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • d78e2be: 8227738: jvmti/DataDumpRequest/datadumpreq001 failed due to "exit code is 134"
  • 8637f65: 8227815: Minimal VM: set_state is not a member of AttachListener
  • f3098c4: 8225690: Multiple AttachListener threads can be created
  • ... and 86 more: https://git.openjdk.java.net/jdk11u-dev/compare/df587c75bb436b40dd995e39ee0ed952a74b979b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jul 27, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jul 27, 2021

Got the push approval.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

Going to push as commit 227610d.
Since your change was applied there have been 96 commits pushed to the master branch:

  • d7a6e51: 8253899: Make IsClassUnloadingEnabled signature match specification
  • 293d44f: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 2a3d908: 8269661: JNI_GetStringCritical does not lock char array
  • 6762216: 8267666: Add option to jcmd GC.heap_dump to use existing file
  • 63c4ec2: 8259535: ECDSA SignatureValue do not always have the specified length
  • 133eca0: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
  • 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server
  • d78e2be: 8227738: jvmti/DataDumpRequest/datadumpreq001 failed due to "exit code is 134"
  • 8637f65: 8227815: Minimal VM: set_state is not a member of AttachListener
  • f3098c4: 8225690: Multiple AttachListener threads can be created
  • ... and 86 more: https://git.openjdk.java.net/jdk11u-dev/compare/df587c75bb436b40dd995e39ee0ed952a74b979b...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jul 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

@shipilev Pushed as commit 227610d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8267348 branch Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants