Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8207011: Remove uses of the register storage class specifier #703

Closed
wants to merge 1 commit into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Dec 8, 2021

Clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8207011: Remove uses of the register storage class specifier

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/703/head:pull/703
$ git checkout pull/703

Update a local copy of the PR:
$ git checkout pull/703
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/703/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 703

View PR using the GUI difftool:
$ git pr show -t 703

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/703.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2021

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6ffd168ad145af0b6fdd72f3130e79b6a1bb9ad0 8207011: Remove uses of the register storage class specifier Dec 8, 2021
@openjdk
Copy link

openjdk bot commented Dec 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 8, 2021

@phohensee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8207011: Remove uses of the register storage class specifier

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • eb2a92f: 8256373: [Windows/HiDPI] The Frame#setBounds does not work in a minimized state

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2021

Webrevs

@phohensee
Copy link
Member Author

/integrate

Got approval.

@openjdk
Copy link

openjdk bot commented Dec 9, 2021

Going to push as commit 98fb4f5.
Since your change was applied there have been 15 commits pushed to the master branch:

  • b68a942: 8266172: -Wstringop-overflow happens in vmError.cpp
  • 99870b4: 8274714: Incorrect verifier protected access error message
  • 16bfc05: 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure
  • a481c9a: 8214761: Bug in parallel Kahan summation implementation
  • eaa4197: 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong
  • 15f3e0e: 8255035: Update BCEL to Version 6.5.0
  • c3aaef3: 8257769: Cipher.getParameters() throws NPE for ChaCha20-Poly1305
  • 9bf52e6: 8233827: Enable screenshots in the enhanced failure handler on Linux/macOS
  • 4beb4ad: 8210236: Prepare ciReceiverTypeData::translate_receiver_data_from for concurrent class unloading
  • 8878ffc: 8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12
  • ... and 5 more: https://git.openjdk.java.net/jdk11u-dev/compare/d0445aa78e9bbf2481eeefb4f89b6c0633a213a9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2021
@openjdk
Copy link

openjdk bot commented Dec 9, 2021

@phohensee Pushed as commit 98fb4f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@phohensee phohensee deleted the backport-6ffd168a branch December 9, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant