Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278309: [windows] use of uninitialized OSThread::_state #706

Closed
wants to merge 1 commit into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Dec 8, 2021

May I please have reviews for this trivial downport. Did not apply cleanly because the surrounding comment confused the cherry picker, but the patch is really trivial.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278309: [windows] use of uninitialized OSThread::_state

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/706/head:pull/706
$ git checkout pull/706

Update a local copy of the PR:
$ git checkout pull/706
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/706/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 706

View PR using the GUI difftool:
$ git pr show -t 706

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/706.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 8, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@tstuefe tstuefe force-pushed the tstuefe-backport-54993b13 branch from 781f5e6 to 94887ca Compare Dec 8, 2021
@openjdk openjdk bot changed the title Backport 54993b13078ceb05736bb0e1d7ed7415c390442e 8278309: [windows] use of uninitialized OSThread::_state Dec 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

@tstuefe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278309: [windows] use of uninitialized OSThread::_state

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 8, 2021
@tstuefe tstuefe marked this pull request as ready for review Dec 8, 2021
@openjdk openjdk bot added the rfr label Dec 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 8, 2021

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Thanks for backporting!

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Dec 15, 2021

Thanks for backporting!

Thank you Martin!

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Dec 20, 2021

Received approval

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 20, 2021

Going to push as commit b07b90f.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 20, 2021
@openjdk openjdk bot closed this Dec 20, 2021
@openjdk openjdk bot removed ready rfr labels Dec 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 20, 2021

@tstuefe Pushed as commit b07b90f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants