Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8214761: Bug in parallel Kahan summation implementation #707

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 8, 2021

I backport this for parity with 11.0.15-oracle.

This includes a new test that is buggy, thus I will push this along with JDK-8273514, which fixes the test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8214761: Bug in parallel Kahan summation implementation

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/707/head:pull/707
$ git checkout pull/707

Update a local copy of the PR:
$ git checkout pull/707
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/707/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 707

View PR using the GUI difftool:
$ git pr show -t 707

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/707.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dd871819a05886ee09fc00c7c778268440ebedb7 8214761: Bug in parallel Kahan summation implementation Dec 8, 2021
@openjdk
Copy link

openjdk bot commented Dec 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 8, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8214761: Bug in parallel Kahan summation implementation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2021

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Dec 9, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 9, 2021

Going to push as commit a481c9a.
Since your change was applied there have been 7 commits pushed to the master branch:

  • eaa4197: 8272473: Parsing epoch seconds at a DST transition with a non-UTC parser is wrong
  • 15f3e0e: 8255035: Update BCEL to Version 6.5.0
  • c3aaef3: 8257769: Cipher.getParameters() throws NPE for ChaCha20-Poly1305
  • 9bf52e6: 8233827: Enable screenshots in the enhanced failure handler on Linux/macOS
  • 4beb4ad: 8210236: Prepare ciReceiverTypeData::translate_receiver_data_from for concurrent class unloading
  • 8878ffc: 8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12
  • 554498d: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2021
@openjdk
Copy link

openjdk bot commented Dec 9, 2021

@GoeLin Pushed as commit a481c9a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant