Skip to content

8273514: java/util/DoubleStreamSums/CompensatedSums.java failure #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 8, 2021

I backport this for parity with 11.0.15-oracle.

A follow up to JDK-8214761.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273514: java/util/DoubleStreamSums/CompensatedSums.java failure

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/708/head:pull/708
$ git checkout pull/708

Update a local copy of the PR:
$ git checkout pull/708
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/708/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 708

View PR using the GUI difftool:
$ git pr show -t 708

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/708.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/707 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f531b5c79633a12efa56c55366e0b7196350e896 8273514: java/util/DoubleStreamSums/CompensatedSums.java failure Dec 8, 2021
@openjdk
Copy link

openjdk bot commented Dec 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Dec 8, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2021

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/707 to master December 9, 2021 12:46
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout GoeLin-backport-dd871819
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Dec 9, 2021
@GoeLin GoeLin force-pushed the goetz_backport_8273514 branch from 2f4ada2 to 555a96d Compare December 9, 2021 12:48
@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Dec 9, 2021
@openjdk
Copy link

openjdk bot commented Dec 9, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273514: java/util/DoubleStreamSums/CompensatedSums.java failure

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 9, 2021
@GoeLin
Copy link
Member Author

GoeLin commented Dec 9, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 9, 2021

Going to push as commit 16bfc05.

@openjdk openjdk bot closed this Dec 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 9, 2021
@GoeLin GoeLin deleted the goetz_backport_8273514 branch December 9, 2021 12:51
@openjdk
Copy link

openjdk bot commented Dec 9, 2021

@GoeLin Pushed as commit 16bfc05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant