8267396: Avoid recording "pc" in unhandled oops detector for better performance

[shipilev]

This improves the performance under -XX:+CheckUnhandledOops. Backport is unclean, because Thread::is_in_stack was renamed to Thread::is_in_live_stack by JDK-8238988.

Additional testing:

• tier1 with -XX:+CheckUnhandledOops

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267396: Avoid recording "pc" in unhandled oops detector for better performance

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/71/head:pull/71
$ git checkout pull/71

Update a local copy of the PR:
$ git checkout pull/71
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/71/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 71

View PR using the GUI difftool:
$ git pr show -t 71

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/71.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267396: Avoid recording "pc" in unhandled oops detector for better performance

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

• d07f6d9: 8227766: CheckUnhandledOops is broken in MemAllocator
• fdaa4f0: 8255810: Zero: build fails without JVMTI
• 3f03476: 8224853: CDS address sanitizer errors
• 65b215a: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
• c61cfb5: 8255718: Zero: VM should know it runs in interpreter-only mode
• 3e09f94: 8260923: Add more tests for SSLSocket input/output shutdown
• c00a72f: 8253631: Remove unimplemented CompileBroker methods after JEP-165
• 21345ef: 8269847: JDK-8269594 backport breaks 11u builds
• 73e987c: 8269594: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark
• 71f793e: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
• ... and 23 more: https://git.openjdk.java.net/jdk11u-dev/compare/df587c75bb436b40dd995e39ee0ed952a74b979b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (8ccf5296)

[shipilev]

On hold: there are weird failures in 11u-dev with -XX:+CheckUnhandledOops. Needs JDK-8227766 to be fixed first, see #73.

[phohensee]

There are four linked issues. I recommend backporting them too, and pushing them together.

[shipilev]

There are four linked issues. I recommend backporting them too, and pushing them together.

I am confused, which four?

[phohensee]

My bad, I was looking at another issue with 4 followups.

[phohensee]

Lgtm.

[shipilev]

Now that JDK-8227766 is in, tier1 passes well.

[shipilev]

/integrate

[openjdk]

Going to push as commit d424c0c.
Since your change was applied there have been 33 commits pushed to the master branch:

• d07f6d9: 8227766: CheckUnhandledOops is broken in MemAllocator
• fdaa4f0: 8255810: Zero: build fails without JVMTI
• 3f03476: 8224853: CDS address sanitizer errors
• 65b215a: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
• c61cfb5: 8255718: Zero: VM should know it runs in interpreter-only mode
• 3e09f94: 8260923: Add more tests for SSLSocket input/output shutdown
• c00a72f: 8253631: Remove unimplemented CompileBroker methods after JEP-165
• 21345ef: 8269847: JDK-8269594 backport breaks 11u builds
• 73e987c: 8269594: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark
• 71f793e: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
• ... and 23 more: https://git.openjdk.java.net/jdk11u-dev/compare/df587c75bb436b40dd995e39ee0ed952a74b979b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit d424c0c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.