8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily

[zhengyu123]

Backport this patch for parity with Oracle 11.0.15.

The patch applies cleanly, but new test does not build. This is due to a couple of CRs [1][2] that affect the test's super class SSLSocketTemplate, are not in jdk11u.

Additional changes to fix the test:

1. Changed member private volatile int serverPort = 0; => protected volatile int serverPort = 0; in SSLSocketTemplate
2. Changed method private void doServerSide() => protected void doServerSide() in SSLSocketTemplate
3. Added member protected volatile InetAddress serverAddress = null; to new test, test never change the value.

Test:

• Passed new test.

[1] JDK-8209362
[2] JDK-8230435

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/711/head:pull/711
$ git checkout pull/711

Update a local copy of the PR:
$ git checkout pull/711
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/711/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 711

View PR using the GUI difftool:
$ git pr show -t 711

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/711.diff

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (19e15931)

[TheRealMDoerr]

LGTM. Thanks for backporting and explaining your adaptations!

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 8878ffc: 8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12
• 554498d: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

/integrate

[zhengyu123]

Got approval, integrated.

[openjdk]

Going to push as commit ec89f1b.
Since your change was applied there have been 26 commits pushed to the master branch:

• b07b90f: 8278309: [windows] use of uninitialized OSThread::_state
• 86c2995: 8202142: jfr/event/io/TestInstrumentation is unstable
• 4b68145: Merge
• d665a4e: 8277529: SIGSEGV in C2 CompilerThread Node::rematerialize() compiling Packet::readUnsignedTrint
• 90c933e: 8207793: [TESTBUG] runtime/Metaspace/FragmentMetaspace.java fails: heap needs to be increased
• 9363d55: 8211170: AArch64: Warnings in C1 and template interpreter
• c94151b: 8273575: memory leak in appendBootClassPath(), paths must be deallocated
• ba1a0e8: 8266187: Memory leak in appendBootClassPath()
• c8c546b: 8240904: Screen flashes on test failures when running tests from make
• b77a165: 8234930: Use MAP_JIT when allocating pages for code cache on macOS
• ... and 16 more: https://git.openjdk.java.net/jdk11u-dev/compare/9b96ac982e755a820a7b830521a68fa32167a52f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@zhengyu123 Pushed as commit ec89f1b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.