Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8065704: Set LC_ALL=C for all relevant commands in the build system #717

Closed
wants to merge 1 commit into from

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Dec 14, 2021

Please review this backport to jdk11u-dev.
This is needed to fix JDK-8278762 which was introduced by backport of JDK-8267246.
It will set LC_ALL=C for all cases now and make result to be 6.25 (instead of 6,25) always, not depending on user's locale setting.
The backport wasn't clean, 3 pieces of compare.sh patch weren't needed and small context code difference in other two chunks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8065704: Set LC_ALL=C for all relevant commands in the build system

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/717/head:pull/717
$ git checkout pull/717

Update a local copy of the PR:
$ git checkout pull/717
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/717/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 717

View PR using the GUI difftool:
$ git pr show -t 717

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/717.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 14, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 54a3efc82980456fc6d8b00cfcb4aa4c786793be 8065704: Set LC_ALL=C for all relevant commands in the build system Dec 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 14, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Dec 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 14, 2021

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

LGTM

Thanks for fixing this.

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Dec 26, 2021

Can I have one more review (from reviewer) on this please ?

Copy link
Member

@phohensee phohensee left a comment

Lgtm.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 27, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8065704: Set LC_ALL=C for all relevant commands in the build system

Reviewed-by: jiefu, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 994276c: 8254827: JVMCI: Enable it for Windows+AArch64
  • 8989823: 8276314: [JVMCI] check alignment of call displacement during code installation
  • fdf21b6: 8265150: AsyncGetCallTrace crashes on ResourceMark
  • 2893731: 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"
  • cd8ea37: 8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
  • fc54784: 8258554: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
  • bf7c965: 8277385: Zero: Enable CompactStrings support
  • bd97b56: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
  • d3c2dc0: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
  • ec89f1b: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily
  • ... and 9 more: https://git.openjdk.java.net/jdk11u-dev/compare/b77a1657575bc392b2e7166b5041ee072189c544...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 27, 2021
@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Dec 29, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 29, 2021

Going to push as commit 6fb1a9e.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 994276c: 8254827: JVMCI: Enable it for Windows+AArch64
  • 8989823: 8276314: [JVMCI] check alignment of call displacement during code installation
  • fdf21b6: 8265150: AsyncGetCallTrace crashes on ResourceMark
  • 2893731: 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"
  • cd8ea37: 8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
  • fc54784: 8258554: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
  • bf7c965: 8277385: Zero: Enable CompactStrings support
  • bd97b56: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
  • d3c2dc0: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
  • ec89f1b: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily
  • ... and 9 more: https://git.openjdk.java.net/jdk11u-dev/compare/b77a1657575bc392b2e7166b5041ee072189c544...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 29, 2021
@openjdk openjdk bot closed this Dec 29, 2021
@openjdk openjdk bot removed ready rfr labels Dec 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 29, 2021

@VladimirKempik Pushed as commit 6fb1a9e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the JDK-8065704 branch Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
3 participants