Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266421: Deadlock in Sound System #719

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 14, 2021

This is the fix for a deadlock introduced in 11.0.2. The patch does not apply cleanly due to changes in the copyright and some changes in the context. The code of the patch is the same. The new test passed.

JBS: https://bugs.openjdk.java.net/browse/JDK-8266421
Review: openjdk/jdk#4141
Commit in jdk17: openjdk/jdk@f6f82c3


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/719/head:pull/719
$ git checkout pull/719

Update a local copy of the PR:
$ git checkout pull/719
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/719/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 719

View PR using the GUI difftool:
$ git pr show -t 719

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/719.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f6f82c31689e68f4263bbbe2314033d69f9049f5 8266421: Deadlock in Sound System Dec 14, 2021
@openjdk
Copy link

openjdk bot commented Dec 14, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 14, 2021
@mrserb mrserb marked this pull request as ready for review December 16, 2021 00:46
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 16, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2021

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Dec 16, 2021

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266421: Deadlock in Sound System

Reviewed-by: phh, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • 00dc442: 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures
  • e79e383: 8273634: [TEST_BUG] Improve javax/swing/text/ParagraphView/6364882/bug6364882.java
  • ffbef52: 8249019: clean up FileInstaller $test.src $cwd in vmTestbase_vm_compiler tests
  • 40d7d03: 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror"
  • 5a3a17b: 8279300: [arm32] SIGILL when running GetObjectSizeIntrinsicsTest
  • f1a15a4: 8273682: Upgrade Jline to 3.20.0
  • 1c7af7e: 8256154: Some TestNG tests require default constructors
  • 5c08cfd: 8237787: rewrite vmTestbase/vm/compiler/CodeCacheInfo* from shell to java
  • c3be035: 8223142: Clean-up WS and CB.
  • 03bfa8c: 8278384: Bytecodes::result_type() for arraylength returns T_VOID instead of T_INT
  • ... and 34 more: https://git.openjdk.java.net/jdk11u-dev/compare/b77a1657575bc392b2e7166b5041ee072189c544...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2022

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@phohensee
Copy link
Member

Keep-Alive

@mrserb
Copy link
Member Author

mrserb commented Jan 21, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 21, 2022

Going to push as commit 716ceb7.
Since your change was applied there have been 101 commits pushed to the master branch:

  • b5cae57: 8274795: AArch64: avoid spilling and restoring r18 in macro assembler
  • 914d48c: 8232533: G1 uses only a single thread for pretouching the java heap
  • ec03928: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • cba6c04: 8268542: serviceability/logging/TestFullNames.java tests only 1st test case
  • 521144c: 8251998: remove usage of PropertyResolvingWrapper in vmTestbase/jit/t
  • f69e75f: 8273438: Enable parallelism in vmTestbase/metaspace/stressHierarchy tests
  • 574c04c: 8273433: Enable parallelism in vmTestbase_nsk_sysdict tests
  • 5ffd40d: 8273341: Update Siphash to version 1.0
  • 0c4803b: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • 3352b56: 8275326: C2: assert(no_dead_loop) failed: dead loop detected
  • ... and 91 more: https://git.openjdk.java.net/jdk11u-dev/compare/b77a1657575bc392b2e7166b5041ee072189c544...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2022
@openjdk openjdk bot closed this Jan 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2022
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@mrserb Pushed as commit 716ceb7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb-backport-f6f82c31 branch January 21, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants