Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269415: [11u] Remove ea from DEFAULT_PROMOTED_VERSION_PRE in OpenJDK 11u #72

Closed
wants to merge 1 commit into from

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 25, 2021

Implement suggested parameter correction as per https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2021-February/005045.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269415: [11u] Remove ea from DEFAULT_PROMOTED_VERSION_PRE in OpenJDK 11u

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/72/head:pull/72
$ git checkout pull/72

Update a local copy of the PR:
$ git checkout pull/72
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/72/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 72

View PR using the GUI difftool:
$ git pr show -t 72

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/72.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 25, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 25, 2021

Webrevs

Loading

Copy link
Contributor

@jerboaa jerboaa left a comment

I'm not sure this is the right move. 11.0.13 (which corresponds to the jdk11u-dev tree) is "Early Access" for all intents and purposes at this time. It should be removed for the -ga tag only and then added back if you'd ask me.

At least that's how I understood Andrew's suggestion on the mailing list.

Loading

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jun 28, 2021

I'm not sure this is the right move. 11.0.13 (which corresponds to the jdk11u-dev tree) is "Early Access" for all intents and purposes at this time. It should be removed for the -ga tag only and then added back if you'd ask me.

Well, my motivation for this change is mainly consistency. For instance in 16u you also find 'DEFAULT_PROMOTED_VERSION_PRE=', without it being changed back and forth in its history. We have never changed such type of release data in the source code so far and I think it's neither feasible nor the right thing to do, given that we use tags for releases.

I'm inclined to read this value like 'ea' designates the major release to be still in development.

After all, this property is only used in Oracle CI builds so far.

Loading

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jun 28, 2021

I'm not sure this is the right move. 11.0.13 (which corresponds to the jdk11u-dev tree) is "Early Access" for all intents and purposes at this time. It should be removed for the -ga tag only and then added back if you'd ask me.

Well, my motivation for this change is mainly consistency. For instance in 16u you also find 'DEFAULT_PROMOTED_VERSION_PRE=', without it being changed back and forth in its history. We have never changed such type of release data in the source code so far and I think it's neither feasible nor the right thing to do, given that we use tags for releases.

I'm inclined to read this value like 'ea' designates the major release to be still in development.

Could be. I now also realize that it's the default for PROMOTED builds, which I suspect will never be EA for update releases.

After all, this property is only used in Oracle CI builds so far.

In the bug you say:

While the value itself is only used by Oracle builds so far, it should still be corrected in OpenJDK to enable downstream vendors to correctly use it. 

This implies to me that we are going to maintain this to be correct going forward. Go from ea to ga at the correct points in time. Could you please clarify this in the bug?

Loading

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jun 28, 2021

This implies to me that we are going to maintain this to be correct going forward. Go from ea to ga at the correct points in time. Could you please clarify this in the bug?

I've updated the bug. Please check whether the description is concise now.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 28, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269415: [11u] Remove ea from DEFAULT_PROMOTED_VERSION_PRE in OpenJDK 11u

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 8a40d25: 8268617: [11u REDO] - WebSocket over authenticating proxy fails with NPE
  • b74d798: 8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description
  • 5a7e7d3: 8265761: Font with missed font family name is not properly printed on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 28, 2021
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jun 29, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

Going to push as commit 52cbf2f.
Since your change was applied there have been 5 commits pushed to the master branch:

  • d522372: 8268771: javadoc -notimestamp option does not work on index.html
  • e62d6a2: 8140466: ChaCha20 and Poly1305 TLS Cipher Suites
  • 8a40d25: 8268617: [11u REDO] - WebSocket over authenticating proxy fails with NPE
  • b74d798: 8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description
  • 5a7e7d3: 8265761: Font with missed font family name is not properly printed on Windows

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@RealCLanger Pushed as commit 52cbf2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@RealCLanger RealCLanger deleted the JDK-8269415 branch Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants